Re: [PATCH] completion: support 'git config --local'

2013-02-12 Thread Matthieu Moy
Jeff King writes: > So yeah. Matthieu's patch is the right thing to do, as it covers both Thanks, > (mine fixed only half of it). (Sorry, I had missed yours) -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a me

Re: [PATCH] completion: support 'git config --local'

2013-02-12 Thread Jeff King
On Tue, Feb 12, 2013 at 02:13:05PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > I'm not sure I understand the original poster's point about "git config > > -l --local". "-l" does not take a limiter, does it? > > "git config -l core.\*" will just die without limiting the output to > ev

Re: [PATCH] completion: support 'git config --local'

2013-02-12 Thread Junio C Hamano
Jeff King writes: > I'm not sure I understand the original poster's point about "git config > -l --local". "-l" does not take a limiter, does it? "git config -l core.\*" will just die without limiting the output to everything under core. hierarchy, so you are right---the combination does not mak

Re: [PATCH] completion: support 'git config --local'

2013-02-12 Thread Jeff King
On Tue, Feb 12, 2013 at 09:34:39AM -0800, Junio C Hamano wrote: > I see the second hunk is new. Comments? > [...] > > @@ -1676,7 +1676,7 @@ _git_config () > > case "$cur" in > > --*) > > __gitcomp " > > - --global --system --file= > > + --sy

Re: [PATCH] completion: support 'git config --local'

2013-02-12 Thread Junio C Hamano
Matthieu Moy writes: > This needs to be done in two places: __git_config_get_set_variables to > allow clever completion of "git config --local --get foo", and > _git_config to allow "git config --loc" to complete to --local. > > While we're there, change the order of options in the code to match

[PATCH] completion: support 'git config --local'

2013-02-12 Thread Matthieu Moy
This needs to be done in two places: __git_config_get_set_variables to allow clever completion of "git config --local --get foo", and _git_config to allow "git config --loc" to complete to --local. While we're there, change the order of options in the code to match git-config.txt. Signed-off-by: