Re: [PATCH] dir.c: fix ignore processing within not-ignored directories

2013-06-04 Thread Karsten Blees
Am 02.06.2013 21:25, schrieb Junio C Hamano: > Duy Nguyen writes: > >>> + then >>> + false >>> + fi >>> +' >> >> Nit pick, maybe this instead? >> >> test_must_fail grep "^one/a.1" output > > Neither. > > ! grep "^one/a.1" output > Nice. I actually tried "!" but

Re: [PATCH] dir.c: fix ignore processing within not-ignored directories

2013-06-02 Thread Junio C Hamano
Duy Nguyen writes: >> + then >> + false >> + fi >> +' > > Nit pick, maybe this instead? > > test_must_fail grep "^one/a.1" output Neither. ! grep "^one/a.1" output The second bullet point in the "Don't" section of t/README may want to be updated to clarify tha

Re: [PATCH] dir.c: fix ignore processing within not-ignored directories

2013-06-01 Thread Duy Nguyen
On Thu, May 30, 2013 at 3:32 AM, Karsten Blees wrote: > As of 95c6f271 "dir.c: unify is_excluded and is_path_excluded APIs", the > is_excluded API no longer recurses into directories that match an ignore > pattern, and returns the directory's ignored state for all contained paths. > > This is OK f

[PATCH] dir.c: fix ignore processing within not-ignored directories

2013-05-29 Thread Karsten Blees
As of 95c6f271 "dir.c: unify is_excluded and is_path_excluded APIs", the is_excluded API no longer recurses into directories that match an ignore pattern, and returns the directory's ignored state for all contained paths. This is OK for normal ignore patterns, i.e. ignoring a directory affects the