Re: [PATCH] fsck: fix leak when traversing trees

2018-01-23 Thread Junio C Hamano
Eric Wong writes: > While fsck_walk/fsck_walk_tree/parse_tree populates "struct tree" > idempotently, it is still up to the fsck_walk caller to call > free_tree_buffer. > > Fixes: ad2db4030e42890e ("fsck: remove redundant parse_tree() invocation") Yup, we can see that that commit did stop freein

[PATCH] fsck: fix leak when traversing trees

2018-01-19 Thread Eric Wong
While fsck_walk/fsck_walk_tree/parse_tree populates "struct tree" idempotently, it is still up to the fsck_walk caller to call free_tree_buffer. Fixes: ad2db4030e42890e ("fsck: remove redundant parse_tree() invocation") Signed-off-by: Eric Wong --- These APIs could probably be made to be less e