Re: [PATCH] git-p4: add "--path-encoding" option

2015-08-31 Thread Junio C Hamano
Torsten Bögershausen writes: > On 2015-08-31 19.40, Junio C Hamano wrote: >> larsxschnei...@gmail.com writes: > >>> +test_expect_success 'Create a repo containing cp1251 encoded paths' ' >>> + cd "$cli" && >>> + >>> + FILENAME="$(echo "a-¤_o-¶_u-¼.txt" | iconv -f utf-8 -t cp1252)" && >> ...

Re: [PATCH] git-p4: add "--path-encoding" option

2015-08-31 Thread Torsten Bögershausen
On 2015-08-31 19.40, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: >> +test_expect_success 'Create a repo containing cp1251 encoded paths' ' >> +cd "$cli" && >> + >> +FILENAME="$(echo "a-¤_o-¶_u-¼.txt" | iconv -f utf-8 -t cp1252)" && > > Hmm, we'd be better off not having a bar

Re: [PATCH] git-p4: add "--path-encoding" option

2015-08-31 Thread Junio C Hamano
larsxschnei...@gmail.com writes: > From: Lars Schneider > > Signed-off-by: Lars Schneider > --- > Documentation/git-p4.txt| 4 > git-p4.py | 6 ++ > t/t9821-git-p4-path-encoding.sh | 38 ++ > 3 files changed, 48 insert

[PATCH] git-p4: add "--path-encoding" option

2015-08-31 Thread larsxschneider
From: Lars Schneider Signed-off-by: Lars Schneider --- Documentation/git-p4.txt| 4 git-p4.py | 6 ++ t/t9821-git-p4-path-encoding.sh | 38 ++ 3 files changed, 48 insertions(+) create mode 100755 t/t9821-git-p4-path-e

[PATCH] git-p4: add "--path-encoding" option

2015-08-31 Thread larsxschneider
From: Lars Schneider Hi, I think I discovered a path encoding issue if you migrate P4 repositories that contain path names generated with Windows. I added a test case to prove my point. Character encoding is a complicated topic. Feedback is highly appreciated. Thanks, Lars Lars Schneider (1