Re: [PATCH] git-parse-remote.sh: Remove op_prep argument

2017-02-03 Thread Junio C Hamano
Pranit Bauva writes: > So if you want a better commit message then you could probably use this, > "parse-remote: remove reference to unused op_prep > > This argument was introduced in the commit 15a147e618 to help in > writing out the error message but then in commit

Re: [PATCH] git-parse-remote.sh: Remove op_prep argument

2017-02-03 Thread Pranit Bauva
Hey Siddharth, On Fri, Feb 3, 2017 at 11:58 PM, Siddharth Kannan wrote: > - Remove the third argument of error_on_missing_default_upstream that is no > longer required > - FIXME to remove this argument was added in commit 045fac5845 This is not exactly correct.

[PATCH] git-parse-remote.sh: Remove op_prep argument

2017-02-03 Thread Siddharth Kannan
- Remove the third argument of error_on_missing_default_upstream that is no longer required - FIXME to remove this argument was added in commit 045fac5845 - Run "grep" on the rest of the codebase to find and remove occurences of the third argument and fix the function calls appropriately