Re: [PATCH] git-sh-setup: Restore sourcability from outside scripts

2016-10-30 Thread Anders Kaseorg
On Sun, 30 Oct 2016, Ævar Arnfjörð Bjarmason wrote: > This did break in v2.10.0, and it's taken a couple of months to notice > this, so clearly it's not very widely used, which says something about > the cost-benefit of maintaining this for external users. For the record, in case this affects the

Re: [PATCH] git-sh-setup: Restore sourcability from outside scripts

2016-10-30 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: (commenting out of order) > It's probably worthwhile to split off git-sh-setup into git-sh-setup & > git-sh-setup-internal along with a documentation fix. A lot of what > it's doing (e.g. git_broken_path_fix(), and adding a die() function) > is

Re: [PATCH] git-sh-setup: Restore sourcability from outside scripts

2016-10-30 Thread Junio C Hamano
Anders Kaseorg writes: > v2.10.0-rc0~45^2~2 “i18n: git-sh-setup.sh: mark strings for > translation” broke outside scripts such as guilt that source > git-sh-setup as described in the documentation: > > $ . "$(git --exec-path)/git-sh-setup" > sh: 6: .: git-sh-i18n: not found > >

Re: [PATCH] git-sh-setup: Restore sourcability from outside scripts

2016-10-30 Thread Ævar Arnfjörð Bjarmason
,On Sun, Oct 30, 2016 at 10:12 PM, Jeff King wrote: > On Sun, Oct 30, 2016 at 08:09:21PM -, Philip Oakley wrote: > >> > It is documented (Documentation/git-sh-setup.txt), and this is not the >> > internal Documentation/technical section of the documentation, so my >> > default

Re: [PATCH] git-sh-setup: Restore sourcability from outside scripts

2016-10-30 Thread Jeff King
On Sun, Oct 30, 2016 at 08:09:21PM -, Philip Oakley wrote: > > It is documented (Documentation/git-sh-setup.txt), and this is not the > > internal Documentation/technical section of the documentation, so my > > default assumption would be that everything shown there is intended as > > public.

Re: [PATCH] git-sh-setup: Restore sourcability from outside scripts

2016-10-30 Thread Philip Oakley
From: "Anders Kaseorg" On Sun, 30 Oct 2016, Ævar Arnfjörð Bjarmason wrote: This seems like a reasonable fix for this issue. However as far as I can tell git-sh-setup was never meant to be used by outside scripts that didn't ship as part of git itself. If that's the case any

Re: [PATCH] git-sh-setup: Restore sourcability from outside scripts

2016-10-30 Thread Anders Kaseorg
On Sun, 30 Oct 2016, Ævar Arnfjörð Bjarmason wrote: > This seems like a reasonable fix for this issue. However as far as I > can tell git-sh-setup was never meant to be used by outside scripts > that didn't ship as part of git itself. > > If that's the case any change in the API which AFAICT is

Re: [PATCH] git-sh-setup: Restore sourcability from outside scripts

2016-10-30 Thread Ævar Arnfjörð Bjarmason
On Sun, Oct 30, 2016 at 3:10 AM, Anders Kaseorg wrote: > v2.10.0-rc0~45^2~2 “i18n: git-sh-setup.sh: mark strings for > translation” broke outside scripts such as guilt that source > git-sh-setup as described in the documentation: > > $ . "$(git --exec-path)/git-sh-setup" > sh: 6:

[PATCH] git-sh-setup: Restore sourcability from outside scripts

2016-10-29 Thread Anders Kaseorg
v2.10.0-rc0~45^2~2 “i18n: git-sh-setup.sh: mark strings for translation” broke outside scripts such as guilt that source git-sh-setup as described in the documentation: $ . "$(git --exec-path)/git-sh-setup" sh: 6: .: git-sh-i18n: not found This also affects