Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-28 Thread Paolo Giarrusso
(Resending without HTML, so that it reaches the ML). On Fri, Oct 11, 2013 at 11:32 AM, Paolo Giarrusso wrote: > > On Wed, Oct 9, 2013 at 11:11 PM, Jonathan Nieder wrote: > > Paolo Giarrusso wrote: > > > >> Seeing the email, I wonder whether there's hope something like that > >> can be preserved

Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-11 Thread Paolo Giarrusso
On Wed, Oct 9, 2013 at 11:11 PM, Jonathan Nieder wrote: > Paolo Giarrusso wrote: > >> Seeing the email, I wonder whether there's hope something like that >> can be preserved in an email, and whether the code should use some >> escape sequence instead. > > Yes, please. Mind if I amend it to > >

Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-09 Thread Jonathan Nieder
Paolo Giarrusso wrote: > Seeing the email, I wonder whether there's hope something like that > can be preserved in an email, and whether the code should use some > escape sequence instead. Yes, please. Mind if I amend it to printf "%s\r" "$revcount/$revmax ($createcount)" >&2 ? [...]

Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-09 Thread Jeff King
On Wed, Oct 09, 2013 at 02:03:24PM +0200, Paolo Giarrusso wrote: > On Wed, Oct 9, 2013 at 1:26 PM, Matthieu Moy > wrote: > > Paolo Giarrusso writes: > > > >> Otherwise, one could > >> change say to use printf, but that's more invasive. > > > > "invasive" in the sense that it impacts indirectly m

Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-09 Thread Paolo Giarrusso
On Wed, Oct 9, 2013 at 1:26 PM, Matthieu Moy wrote: > Paolo Giarrusso writes: > >> Otherwise, one could >> change say to use printf, but that's more invasive. > > "invasive" in the sense that it impacts indirectly more callers, but are > there really cases where "echo" is needed when calling "say

Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-09 Thread Matthieu Moy
Paolo Giarrusso writes: > Otherwise, one could > change say to use printf, but that's more invasive. "invasive" in the sense that it impacts indirectly more callers, but are there really cases where "echo" is needed when calling "say"? Aren't there other potential bugs when arbitrary strings are

Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-09 Thread Johannes Sixt
Am 10/9/2013 12:32, schrieb Paolo Giarrusso: > On Wed, Oct 9, 2013 at 12:20 PM, Tay Ray Chuan wrote: >> On Wed, Oct 9, 2013 at 11:57 AM, Paolo G. Giarrusso >> wrote: >>> diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh >>> index 7d7af03..ebfb78f 100755 >>> --- a/contri

Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-09 Thread Paolo Giarrusso
(Resending without HTML). On Wed, Oct 9, 2013 at 12:20 PM, Tay Ray Chuan wrote: > > On Wed, Oct 9, 2013 at 11:57 AM, Paolo G. Giarrusso > wrote: > > diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh > > index 7d7af03..ebfb78f 100755 > > --- a/contrib/subtree/git-subtre

Re: [PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-09 Thread Tay Ray Chuan
On Wed, Oct 9, 2013 at 11:57 AM, Paolo G. Giarrusso wrote: > diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh > index 7d7af03..ebfb78f 100755 > --- a/contrib/subtree/git-subtree.sh > +++ b/contrib/subtree/git-subtree.sh > @@ -592,7 +592,9 @@ cmd_split() > eval "

[PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-08 Thread Paolo G. Giarrusso
Since say uses echo, this uses echo -n, which is not portable - see 19c3c5fdcb35b66b792534c5dc4e8d87a3952d2a. Without this commit, the output looks like: ... -n 1891/1936 (1883) -n 1892/1936 (1884) -n 1893/1936 (1885) ... Signed-off-by: Paolo G. Giarrusso --- Please CC me on replie