Re: [PATCH] grep: fix build with no thread support

2017-03-17 Thread Jeff King
On Fri, Mar 17, 2017 at 03:42:32PM -0700, Brandon Williams wrote: > > > I didn't take a close look at it but this would seem to indicate that we > > > don't worry to much about systems without pthreads support. Just food > > > for thought. > > > > Hmm. We used to. What version did you test?

Re: [PATCH] grep: fix build with no thread support

2017-03-17 Thread Brandon Williams
On 03/17, Jeff King wrote: > On Fri, Mar 17, 2017 at 03:42:32PM -0700, Brandon Williams wrote: > > > > > I didn't take a close look at it but this would seem to indicate that we > > > > don't worry to much about systems without pthreads support. Just food > > > > for thought. > > > > > > Hmm.

Re: [PATCH] grep: fix build with no thread support

2017-03-17 Thread Brandon Williams
On 03/17, Jeff King wrote: > On Fri, Mar 17, 2017 at 11:47:01AM -0700, Brandon Williams wrote: > > > While taking a look at this bug I discovered that the test suite doesn't > > pass 100% of the test when compiled with the NO_PTHREADS option. The > > following tests seem to be failing: > > > >

Re: [PATCH] grep: fix build with no thread support

2017-03-17 Thread Jeff King
On Fri, Mar 17, 2017 at 11:47:01AM -0700, Brandon Williams wrote: > While taking a look at this bug I discovered that the test suite doesn't > pass 100% of the test when compiled with the NO_PTHREADS option. The > following tests seem to be failing: > > t1060-object-corruption.sh

Re: [PATCH] grep: fix build with no thread support

2017-03-17 Thread Brandon Williams
While taking a look at this bug I discovered that the test suite doesn't pass 100% of the test when compiled with the NO_PTHREADS option. The following tests seem to be failing: t1060-object-corruption.sh (Wstat: 256 Tests: 13 Failed: 3) Failed tests: 7-9 Non-zero exit

Re: [PATCH] grep: fix build with no thread support

2017-03-17 Thread Brandon Williams
On 03/17, Junio C Hamano wrote: > Rahul Bedarkar writes: > > > diff --git a/builtin/grep.c b/builtin/grep.c > > index 2c727ef..4373d79 100644 > > --- a/builtin/grep.c > > +++ b/builtin/grep.c > > @@ -183,11 +183,13 @@ static void *run(void *arg) > > if (!w)

Re: [PATCH] grep: fix build with no thread support

2017-03-17 Thread Junio C Hamano
Rahul Bedarkar writes: > diff --git a/builtin/grep.c b/builtin/grep.c > index 2c727ef..4373d79 100644 > --- a/builtin/grep.c > +++ b/builtin/grep.c > @@ -183,11 +183,13 @@ static void *run(void *arg) > if (!w) > break; > > -

[PATCH] grep: fix build with no thread support

2017-03-16 Thread Rahul Bedarkar
Commit 0281e487fd91 ("grep: optionally recurse into submodules") added functions grep_submodule() and grep_submodule_launch() which uses "struct work_item" which is defined only when thread support is available. When building git with toolchain that don't have thread support, we get following