Hi,
On Fri, May 16, 2014 at 04:29:58AM -0400, Jeff King wrote:
> [..] I hope I did not sound like "blame Stepan, he was screwed up".
no, you did not, it was ok.
> From msysgit's perspective, they may or may not want to revert the patch
> that they already have. That is a _separate_ issue, and I
On Fri, May 16, 2014 at 10:19:57AM +0200, Stepan Kasal wrote:
> On Thu, May 15, 2014 at 03:22:26PM -0400, Jeff King wrote:
> > As the person who is proposing the patch for git.git, I would hope
> > Stepan would follow up on such review and confirm whether or not it is
> > still needed.
>
> well,
Hello,
On Thu, May 15, 2014 at 03:22:26PM -0400, Jeff King wrote:
> As the person who is proposing the patch for git.git, I would hope
> Stepan would follow up on such review and confirm whether or not it is
> still needed.
well, I try to. (I verified that "less -I" works in msysGit before
submi
On Thu, May 15, 2014 at 07:42:00PM +0200, Johannes Schindelin wrote:
> > Hrm. Is this patch still necessary? In the time since this patch was
> > written, we did 0826579 (grep: load file data after checking
> > binary-ness, 2012-02-02)
>
> I have no time to test this but I trust that you made sur
Hi Peff,
On Wed, 14 May 2014, Jeff King wrote:
> On Wed, May 14, 2014 at 05:44:19PM +0200, Stepan Kasal wrote:
>
> > From: Johannes Schindelin
> > Date: Mon, 8 Nov 2010 16:10:43 +0100
> >
> > Incidentally, this makes grep -I respect the "binary" attribute (actually,
> > the "-text" attribute,
Jeff King writes:
> On Wed, May 14, 2014 at 05:44:19PM +0200, Stepan Kasal wrote:
>
>> From: Johannes Schindelin
>> Date: Mon, 8 Nov 2010 16:10:43 +0100
>>
>> Incidentally, this makes grep -I respect the "binary" attribute (actually,
>> the "-text" attribute, but "binary" implies that).
>>
>>
On Wed, May 14, 2014 at 10:52:28AM -0700, Junio C Hamano wrote:
> I do not think checking 'text' is the right way to do this. The
> attribute controls the eof normalization, and people sometimes want
> to keep CRLF terminated files in the repository no matter what the
> platform is (an example I
On Wed, May 14, 2014 at 05:44:19PM +0200, Stepan Kasal wrote:
> From: Johannes Schindelin
> Date: Mon, 8 Nov 2010 16:10:43 +0100
>
> Incidentally, this makes grep -I respect the "binary" attribute (actually,
> the "-text" attribute, but "binary" implies that).
>
> Since the attributes are not t
Stepan Kasal writes:
> From: Johannes Schindelin
> Date: Mon, 8 Nov 2010 16:10:43 +0100
>
> Incidentally, this makes grep -I respect the "binary" attribute (actually,
> the "-text" attribute, but "binary" implies that).
>
> Since the attributes are not thread-safe, we now need to switch off
> th
From: Johannes Schindelin
Date: Mon, 8 Nov 2010 16:10:43 +0100
Incidentally, this makes grep -I respect the "binary" attribute (actually,
the "-text" attribute, but "binary" implies that).
Since the attributes are not thread-safe, we now need to switch off
threading if -I was passed.
Signed-off
10 matches
Mail list logo