Re: [PATCH] http: fix some printf format warnings on 32-bit builds

On 13 Nov 2015, at 21:02, Ramsay Jones wrote: > > > On 13/11/15 08:57, Eric Sunshine wrote: >> On Fri, Nov 13, 2015 at 3:46 AM, Lars Schneider >> wrote: >>> On 11 Nov 2015, at 18:49, Ramsay Jones wrote:

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

On 2015-11-13 09.57, Eric Sunshine wrote: > On Fri, Nov 13, 2015 at 3:46 AM, Lars Schneider > wrote: >> On 11 Nov 2015, at 18:49, Ramsay Jones wrote: >>> On 11/11/15 02:00, Stefan Beller wrote: On Tue, Nov 10, 2015 at 5:22 PM, Eric

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

> On 13 Nov 2015, at 11:32, Torsten Bögershausen wrote: > > On 2015-11-13 09.57, Eric Sunshine wrote: >> On Fri, Nov 13, 2015 at 3:46 AM, Lars Schneider >> wrote: >>> On 11 Nov 2015, at 18:49, Ramsay Jones wrote: On

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

On 11 Nov 2015, at 18:49, Ramsay Jones wrote: > > > On 11/11/15 02:00, Stefan Beller wrote: >> On Tue, Nov 10, 2015 at 5:22 PM, Eric Sunshine >> wrote: >>> On Tue, Nov 10, 2015 at 7:23 PM, Ramsay Jones >>>

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

On Fri, Nov 13, 2015 at 3:46 AM, Lars Schneider wrote: > On 11 Nov 2015, at 18:49, Ramsay Jones wrote: >> On 11/11/15 02:00, Stefan Beller wrote: >>> On Tue, Nov 10, 2015 at 5:22 PM, Eric Sunshine >>> wrote:

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

On 13/11/15 08:57, Eric Sunshine wrote: > On Fri, Nov 13, 2015 at 3:46 AM, Lars Schneider > wrote: >> On 11 Nov 2015, at 18:49, Ramsay Jones wrote: >>> On 11/11/15 02:00, Stefan Beller wrote: On Tue, Nov 10, 2015 at 5:22 PM, Eric

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

On 12/11/15 05:27, Torsten Bögershausen wrote: >>Ah. OK, so %ld for long and %lld for long long, I suppose. > Only if you have a system that's support it. > > Linux does, Windows not. Sure, but I was speculating specifically about Eric's mac (which I have no experience with). > >> Hmm, not

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

Torsten Bögershausen writes: > So whenever a long long is printed, I can warmly recommend to use > > PRId64 PRId64 is not suitable for long long, only for int64_t. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

On 11/11/15 01:22, Eric Sunshine wrote: > On Tue, Nov 10, 2015 at 7:23 PM, Ramsay Jones > wrote: >> Commit f8117f55 ("http: use off_t to store partial file size", >> 02-11-2015) changed the type of some variables from long to off_t. >> The 32-bit build, which

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

On 11/11/15 02:00, Stefan Beller wrote: > On Tue, Nov 10, 2015 at 5:22 PM, Eric Sunshine > wrote: >> On Tue, Nov 10, 2015 at 7:23 PM, Ramsay Jones >> wrote: >>> Commit f8117f55 ("http: use off_t to store partial file size", >>> 02-11-2015)

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

On Wed, Nov 11, 2015 at 12:02 AM, Lars Schneider wrote: > > Unfortunately no. All their machines are 64-bit [1] and they have "no > immediate plans to add this feature" [2]. > However, we could the following build configuration on a 64-bit machine: > > export

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

>Ah. OK, so %ld for long and %lld for long long, I suppose. Only if you have a system that's support it. Linux does, Windows not. Hmm, not that it matters, but I wonder what the PRId64 macro is. ;-) It's "I64d" for Windows, and "lld" for all Gnu based systems and others, When you do

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

On Wed, Nov 11, 2015 at 03:31:01PM -0500, Eric Sunshine wrote: > The fact that 'long' and 'long long' happen to be the same size (in > this case) is immaterial. What is important is that the code is just > wrong to be using the "%l" specifier for 'long' when the actual > datatype is 'long long'

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

On 11/11/15 20:31, Eric Sunshine wrote: > On Wed, Nov 11, 2015 at 12:47 PM, Ramsay Jones > wrote: >> On 11/11/15 01:22, Eric Sunshine wrote: >>> On Tue, Nov 10, 2015 at 7:23 PM, Ramsay Jones >>> wrote: >>> My machine is 64-bit, though,

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

On Wed, Nov 11, 2015 at 12:47 PM, Ramsay Jones wrote: > On 11/11/15 01:22, Eric Sunshine wrote: >> On Tue, Nov 10, 2015 at 7:23 PM, Ramsay Jones >> wrote: >> My machine is 64-bit, though, so perhaps it's misleading to >> characterize this

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

On 11 Nov 2015, at 03:00, Stefan Beller wrote: > On Tue, Nov 10, 2015 at 5:22 PM, Eric Sunshine > wrote: >> On Tue, Nov 10, 2015 at 7:23 PM, Ramsay Jones >> wrote: >>> Commit f8117f55 ("http: use off_t to store partial

[PATCH] http: fix some printf format warnings on 32-bit builds

Commit f8117f55 ("http: use off_t to store partial file size", 02-11-2015) changed the type of some variables from long to off_t. The 32-bit build, which enables the large filesystem interface (_FILE_OFFSET_BITS == 64), defines the off_t type as a 64-bit integer, whereas long is a 32-bit integer.

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

On Tue, Nov 10, 2015 at 7:23 PM, Ramsay Jones wrote: > Commit f8117f55 ("http: use off_t to store partial file size", > 02-11-2015) changed the type of some variables from long to off_t. > The 32-bit build, which enables the large filesystem interface >

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

On Tue, Nov 10, 2015 at 5:22 PM, Eric Sunshine wrote: > On Tue, Nov 10, 2015 at 7:23 PM, Ramsay Jones > wrote: >> Commit f8117f55 ("http: use off_t to store partial file size", >> 02-11-2015) changed the type of some variables from long to