Re: [PATCH] http.c: fix parsing of http.sslCertPasswordProtected variable

2013-07-15 Thread Junio C Hamano
"Kyle J. McKay" writes: > That works fine for GIT_SSL_CERT_PASSWORD_PROTECTED and > GIT_CURL_VERBOSE, but it's a little bit awkward for GIT_SSL_NO_VERIFY > and GIT_CURL_FTP_NO_EPSV since they have "_NO_" in their names. > > If the user wants to override a "http.sslVerify=false" then > "GIT_SSL_NO

Re: [PATCH] http.c: fix parsing of http.sslCertPasswordProtected variable

2013-07-14 Thread Kyle J. McKay
On Jul 14, 2013, at 21:13, Junio C Hamano wrote: Mark Lodato writes: On Fri, Jul 12, 2013 at 3:52 PM, Junio C Hamano wrote: Jonathan Nieder writes: FWIW the GIT_SSL_CERT_PASSWORD_PROTECTED envvar has a similar "can only enable" behavior, but since it's documented, that's not as big of a

Re: [PATCH] http.c: fix parsing of http.sslCertPasswordProtected variable

2013-07-14 Thread Junio C Hamano
Mark Lodato writes: > On Fri, Jul 12, 2013 at 3:52 PM, Junio C Hamano wrote: >> >> Jonathan Nieder writes: >> >> > FWIW the GIT_SSL_CERT_PASSWORD_PROTECTED envvar has a similar "can >> > only enable" behavior, but since it's documented, that's not as big >> > of a problem. Do you remember why

Re: [PATCH] http.c: fix parsing of http.sslCertPasswordProtected variable

2013-07-13 Thread Mark Lodato
On Fri, Jul 12, 2013 at 3:52 PM, Junio C Hamano wrote: > > Jonathan Nieder writes: > > > FWIW the GIT_SSL_CERT_PASSWORD_PROTECTED envvar has a similar "can > > only enable" behavior, but since it's documented, that's not as big > > of a problem. Do you remember why it was written that way? > > N

Re: [PATCH] http.c: fix parsing of http.sslCertPasswordProtected variable

2013-07-13 Thread Kyle J. McKay
On Jul 12, 2013, at 12:05, Jonathan Nieder wrote: > Junio C Hamano wrote: > >> The existing code triggers only when the configuration variable is >> set to true. Once the variable is set to true in a more generic >> configuration file (e.g. ~/.gitconfig), it cannot be overriden to >> false in the

Re: [PATCH] http.c: fix parsing of http.sslCertPasswordProtected variable

2013-07-12 Thread Junio C Hamano
Jonathan Nieder writes: > FWIW the GIT_SSL_CERT_PASSWORD_PROTECTED envvar has a similar "can > only enable" behavior, but since it's documented, that's not as big > of a problem. Do you remember why it was written that way? Not me ;-). If I have to guess, it is probably that these two are thou

Re: [PATCH] http.c: fix parsing of http.sslCertPasswordProtected variable

2013-07-12 Thread Jonathan Nieder
Junio C Hamano wrote: > The existing code triggers only when the configuration variable is > set to true. Once the variable is set to true in a more generic > configuration file (e.g. ~/.gitconfig), it cannot be overriden to > false in the repository specific one (e.g. .git/config). [...] > --- a

[PATCH] http.c: fix parsing of http.sslCertPasswordProtected variable

2013-07-12 Thread Junio C Hamano
The existing code triggers only when the configuration variable is set to true. Once the variable is set to true in a more generic configuration file (e.g. ~/.gitconfig), it cannot be overriden to false in the repository specific one (e.g. .git/config). Signed-off-by: Junio C Hamano --- http.c