Re: [PATCH] log: use true parents for diff when walking reflogs

2013-08-05 Thread Junio C Hamano
Thomas Rast writes: > The reflog walking logic (git log -g) replaces the true parent list > with the preceding commit in the reflog. This results in bogus commit > diffs when combined with options such as -p; the diff is against the > reflog predecessor, not the parent of the commit. > > Save th

Re: [PATCH] log: use true parents for diff when walking reflogs

2013-08-03 Thread Thomas Rast
Doh, once again I forgot the in-reply-to. This patch continues the thread after <20130731225520.gb25...@sigill.intra.peff.net>. This is -- strangely enough -- missing from gmane; its immediate predecessor is this: http://thread.gmane.org/gmane.comp.version-control.git/230968/focus=231453 Sorr

[PATCH] log: use true parents for diff when walking reflogs

2013-08-03 Thread Thomas Rast
The reflog walking logic (git log -g) replaces the true parent list with the preceding commit in the reflog. This results in bogus commit diffs when combined with options such as -p; the diff is against the reflog predecessor, not the parent of the commit. Save the true parents on the side, exten