Re: [PATCH] mingw: introduce the 'core.hideDotFiles' setting

2016-05-07 Thread Johannes Schindelin
Hi Junio, On Fri, 6 May 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> I agree with the goal of the change, but I am having a hard time > >> justifying this addition. Primarily because I do not understand the > >> need for this. > >> > >> In

Re: [PATCH] mingw: introduce the 'core.hideDotFiles' setting

2016-05-06 Thread Junio C Hamano
Junio C Hamano writes: > If you are sure we do not need that, that is one less reason we > would be better off without mark_as_git_dir(). Oops. To many rounds of rewriting followed by a rather careless final round of reading. I couldn't decide between "That is one less

Re: [PATCH] mingw: introduce the 'core.hideDotFiles' setting

2016-05-06 Thread Junio C Hamano
Johannes Schindelin writes: >> I agree with the goal of the change, but I am having a hard time >> justifying this addition. Primarily because I do not understand the >> need for this. >> >> In order to be prepared to handle HIDE_DOTFILES_TRUE case, >> mingw_mkdir()

Re: [PATCH] mingw: introduce the 'core.hideDotFiles' setting

2016-05-06 Thread Johannes Schindelin
Hi Junio, On Wed, 4 May 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > diff --git a/builtin/init-db.c b/builtin/init-db.c > > index b2d8d40..c4269ac 100644 > > --- a/builtin/init-db.c > > +++ b/builtin/init-db.c > > @@ -370,6 +370,7 @@ int

Re: [PATCH] mingw: introduce the 'core.hideDotFiles' setting

2016-05-04 Thread Junio C Hamano
Johannes Schindelin writes: > diff --git a/builtin/init-db.c b/builtin/init-db.c > index b2d8d40..c4269ac 100644 > --- a/builtin/init-db.c > +++ b/builtin/init-db.c > @@ -370,6 +370,7 @@ int init_db(const char *template_dir, unsigned int flags) >

Re: [PATCH] mingw: introduce the 'core.hideDotFiles' setting

2016-05-04 Thread Ramsay Jones
On 04/05/16 15:40, Johannes Schindelin wrote: > From: Erik Faye-Lund > > On Unix (and Linux) it is common that files and directories whose names > start with a dot are not shown by default. This convention is used by Git: > the .git/ directory should be left alone by

[PATCH] mingw: introduce the 'core.hideDotFiles' setting

2016-05-04 Thread Johannes Schindelin
From: Erik Faye-Lund On Unix (and Linux) it is common that files and directories whose names start with a dot are not shown by default. This convention is used by Git: the .git/ directory should be left alone by regular users, and only accessed through Git itself. On