Hi,
I put following printf logs.
int checkout_entry(struct cache_entry *ce,
const struct checkout *state, char *topath)
{
static char path[PATH_MAX + 1];
struct stat st;
int len = state->base_dir_len;
if (topath)
return write_en
On Thu, Oct 3, 2013 at 7:25 PM, Antoine Pelisse wrote:
> I've not followed the thread so much but, in that
> entry.c::checkout_entry,() we do:
>
> memcpy(path, state->base_dir, len);
> strcpy(path + len, ce->name);
>
> which can of course result in memory violation if PATH is not long enough.
>
.
I've not followed the thread so much but, in that
entry.c::checkout_entry,() we do:
memcpy(path, state->base_dir, len);
strcpy(path + len, ce->name);
which can of course result in memory violation if PATH is not long enough.
On Thu, Oct 3, 2013 at 12:26 AM, Wataru Noguchi wrote:
> Hi,
>
> At la
Hi,
At last, I foundfollowing Makefile optimization suppression works fine in my
case.
CFLAGS = -g -O2 -fno-inline-small-functions -Wall
Following optimization option cause crash,
-finline-small-functions
// entry.c:237
int checkout_entry(struct cache_entry *ce,
const st
Hi,
Thanks for your advice.
I see. I'll try following tool for optimization affection.
Thanks.
(2013/09/29 20:01), Stefan Beller wrote:
On 09/29/2013 04:56 AM, Wataru Noguchi wrote:
- gcc optimization level is O2.(fail)
- gcc O0, O1 works fine.
Maybe you could try to compile with
STACK fo
Hi,
Thanks for your patch.
Unfortunately, in my case still crash...
But PATH_MAX length kinds issues interesting.
I'll try investigate a little more.
- PATH_MAX and O2
Thanks.
(2013/10/01 2:00), René Scharfe wrote:
Am 29.09.2013 04:56, schrieb Wataru Noguchi:
Hi,
Thanks for comments.
My
On Mon, Sep 30, 2013 at 7:00 PM, René Scharfe wrote:
> Am 29.09.2013 04:56, schrieb Wataru Noguchi:
>> Hi,
>>
>> Thanks for comments.
>>
>> My currently working repository is
>>
>> https://github.com/wnoguchi/git/tree/hotfix/mingw-multibyte-path-checkout-failure
>>
>> I have revert commits to 1f10
Am 29.09.2013 04:56, schrieb Wataru Noguchi:
> Hi,
>
> Thanks for comments.
>
> My currently working repository is
>
> https://github.com/wnoguchi/git/tree/hotfix/mingw-multibyte-path-checkout-failure
>
> I have revert commits to 1f10da3.
> I'll try failure step.
>
> - gcc optimization level i
On 09/29/2013 04:56 AM, Wataru Noguchi wrote:
>
> - gcc optimization level is O2.(fail)
> - gcc O0, O1 works fine.
Maybe you could try to compile with
STACK found at http://css.csail.mit.edu/stack/
That tool is designed to find
Optimization-unstable code.
signature.asc
Description: OpenPGP d
Hi,
Thanks for comments.
My currently working repository is
https://github.com/wnoguchi/git/tree/hotfix/mingw-multibyte-path-checkout-failure
I have revert commits to 1f10da3.
I'll try failure step.
- gcc optimization level is O2.(fail)
- gcc O0, O1 works fine.
$ gdb git-clone
GNU gdb 6.8
C
Hi,
On Sun, 29 Sep 2013, Wataru Noguchi wrote:
> --- a/convert.c
> +++ b/convert.c
> @@ -724,6 +724,11 @@ static void convert_attrs(struct conv_attrs *ca, const
> char *path)
> {
> int i;
> static struct git_attr_check ccheck[NUM_CONV_ATTRS];
> +
> + if (NUM_CONV_ATTRS != 0
fix: Git for Windows crashes when clone Japanese multibyte repository.
Reproduce condition:
- Japanese Base Encoding is Shift-JIS.
- It happens Japanese multibyte directory name and too-long directory path
- Linux(ex. Ubuntu 13.04 amd64) can clone normally.
- example repository is here:
git clon
12 matches
Mail list logo
