Re: [PATCH] notes: add `rm` and `delete` commands

2017-11-10 Thread Adam Dinwoodie
On Friday 10 November 2017 at 12:14 pm +0900, Junio C Hamano wrote: > Eric Sunshine writes: > > > or against the change: > > > > - synonym bloat; balloons documentation > > - steals command verbs from potential future features > > - ... > > I tend to agree

Re: [PATCH] notes: add `rm` and `delete` commands

2017-11-09 Thread Junio C Hamano
Eric Sunshine writes: > or against the change: > > - synonym bloat; balloons documentation > - steals command verbs from potential future features > - ... I tend to agree with these two (and if I were to replace the "..." with something concrete, this change

Re: [PATCH] notes: add `rm` and `delete` commands

2017-11-09 Thread Eric Sunshine
On Thu, Nov 9, 2017 at 8:46 AM, Adam Dinwoodie wrote: > Add `git notes rm` and `git notes delete` as alternative ways of saying > `git notes remove`. The justification for this change seems to be missing from the commit message. One can formulate arguments for the change:

[PATCH] notes: add `rm` and `delete` commands

2017-11-09 Thread Adam Dinwoodie
Add `git notes rm` and `git notes delete` as alternative ways of saying `git notes remove`. Signed-off-by: Adam Dinwoodie --- Documentation/git-notes.txt | 4 +++- builtin/notes.c | 8 +--- t/t3301-notes.sh| 6 +++--- 3 files changed, 11