Re: [PATCH] refs.c: repack_without_refs may be called without error string buffer

2014-11-20 Thread Stefan Beller
ok, will drop the patch due to bad design. On Thu, Nov 20, 2014 at 10:36 AM, Ronnie Sahlberg wrote: > On Thu, Nov 20, 2014 at 10:35 AM, Jonathan Nieder wrote: >> Stefan Beller wrote: >> >>> If we don't pass in the error string buffer, we skip over all >>> parts dealing with preparing error messa

Re: [PATCH] refs.c: repack_without_refs may be called without error string buffer

2014-11-20 Thread Ronnie Sahlberg
On Thu, Nov 20, 2014 at 10:35 AM, Jonathan Nieder wrote: > Stefan Beller wrote: > >> If we don't pass in the error string buffer, we skip over all >> parts dealing with preparing error messages. > > Please no. > > We tried this with the ref transaction code. When someone wants > to silence the me

Re: [PATCH] refs.c: repack_without_refs may be called without error string buffer

2014-11-20 Thread Jonathan Nieder
Stefan Beller wrote: > If we don't pass in the error string buffer, we skip over all > parts dealing with preparing error messages. Please no. We tried this with the ref transaction code. When someone wants to silence the message, it is cheap enough to do struct strbuf ignore = STRBUF_

Re: [PATCH] refs.c: repack_without_refs may be called without error string buffer

2014-11-20 Thread Ronnie Sahlberg
On Thu, Nov 20, 2014 at 10:10 AM, Stefan Beller wrote: > If we don't pass in the error string buffer, we skip over all > parts dealing with preparing error messages. > > Signed-off-by: Stefan Beller > --- > > This goes ontop of [PATCH v5] refs.c: use a stringlist for repack_without_refs > if that

[PATCH] refs.c: repack_without_refs may be called without error string buffer

2014-11-20 Thread Stefan Beller
If we don't pass in the error string buffer, we skip over all parts dealing with preparing error messages. Signed-off-by: Stefan Beller --- This goes ontop of [PATCH v5] refs.c: use a stringlist for repack_without_refs if that makes sense. refs.c | 8 refs.h | 1 - 2 files changed, 4