Re: [PATCH] regex: do not call `regfree()` if compilation fails

On 22 May 2018 at 04:20, Eric Sunshine wrote: > On Mon, May 21, 2018 at 2:43 PM, Stefan Beller wrote: >> On Sun, May 20, 2018 at 3:50 AM, Martin Ågren wrote: >>> It is apparently undefined behavior to call `regfree()` on a

Re: [PATCH] regex: do not call `regfree()` if compilation fails

On Mon, May 21, 2018 at 2:43 PM, Stefan Beller wrote: > On Sun, May 20, 2018 at 3:50 AM, Martin Ågren wrote: >> It is apparently undefined behavior to call `regfree()` on a regex where >> `regcomp()` failed. [...] >> >> diff --git a/diffcore-pickaxe.c

Re: [PATCH] regex: do not call `regfree()` if compilation fails

On Sun, May 20, 2018 at 3:50 AM, Martin Ågren wrote: > It is apparently undefined behavior to call `regfree()` on a regex where > `regcomp()` failed. The language in [1] is a bit muddy, at least to me, > but the clearest hint is this (`preg` is the `regex_t *`): > >

[PATCH] regex: do not call `regfree()` if compilation fails

It is apparently undefined behavior to call `regfree()` on a regex where `regcomp()` failed. The language in [1] is a bit muddy, at least to me, but the clearest hint is this (`preg` is the `regex_t *`): Upon successful completion, the regcomp() function shall return 0. Otherwise, it