Re: [PATCH] regex: fix a SIZE_MAX macro redefinition warning

Ramsay Jones writes: > The original version of this patch looked like this: > ... > So, just move the unconditional inclusion to the start of the compilation > unit root file, before the #include of the regex_internal.h header. > > In some ways this is a better fix,

Re: [PATCH] regex: fix a SIZE_MAX macro redefinition warning

Hi Ramsay, On Sun, 5 Jun 2016, Ramsay Jones wrote: > > Other than that, I think this patch is an improvement. > > Thanks. What do you think of replacing it with the original patch > (above)? That would work for me, too. Thanks, Dscho -- To unsubscribe from this list: send the line

Re: [PATCH] regex: fix a SIZE_MAX macro redefinition warning

On 05/06/16 08:15, Johannes Schindelin wrote: > Hi Ramsay, > > thanks for working on this! > > On Sat, 4 Jun 2016, Ramsay Jones wrote: > >> diff --git a/Makefile b/Makefile >> index 0d59718..3f6c70a 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -1987,7 +1987,7 @@ endif >> >> ifdef

Re: [PATCH] regex: fix a SIZE_MAX macro redefinition warning

Hi Ramsay, thanks for working on this! On Sat, 4 Jun 2016, Ramsay Jones wrote: > diff --git a/Makefile b/Makefile > index 0d59718..3f6c70a 100644 > --- a/Makefile > +++ b/Makefile > @@ -1987,7 +1987,7 @@ endif > > ifdef NO_REGEX > compat/regex/regex.sp compat/regex/regex.o: EXTRA_CPPFLAGS =

[PATCH] regex: fix a SIZE_MAX macro redefinition warning

Since commit 56a1a3ab ("Silence GCC's \"cast of pointer to integer of a different size\" warning", 26-10-2015), sparse has been issuing a macro redefinition warning for the SIZE_MAX macro. However, gcc did not issue any such warning. After commit 56a1a3ab, in terms of the order of #includes and