Re: [PATCH] repack: Add --version parameter

2013-09-28 Thread Stefan Beller
On 09/26/2013 12:17 PM, Felipe Contreras wrote: On Thu, Sep 26, 2013 at 3:32 AM, Stefan Beller static const char *const git_repack_usage[] = { @@ -22,6 +23,9 @@ static int repack_config(const char *var, const char *value, void *cb) delta_base_offset = git_config_bool(var,

Re: [PATCH] repack: Add --version parameter

2013-09-28 Thread Stefan Beller
On 09/26/2013 01:42 PM, Duy Nguyen wrote: On Thu, Sep 26, 2013 at 3:32 PM, Stefan Beller stefanbel...@googlemail.com wrote: This is just a direct translation of http://article.gmane.org/gmane.comp.version-control.git/235396 So I don't consider this is ready for inclusion. Some notes: We

[PATCH] repack: Add --version parameter

2013-09-26 Thread Stefan Beller
This is just a direct translation of http://article.gmane.org/gmane.comp.version-control.git/235396 So I don't consider this is ready for inclusion. Some notes: We need to have more error checking, repack shall be 0, 2 or 4 but nothing else. If 0 is given, no argument is passed to pack-objects,

Re: [PATCH] repack: Add --version parameter

2013-09-26 Thread Felipe Contreras
On Thu, Sep 26, 2013 at 3:32 AM, Stefan Beller stefanbel...@googlemail.com wrote: This is just a direct translation of http://article.gmane.org/gmane.comp.version-control.git/235396 So I don't consider this is ready for inclusion. Some notes: We need to have more error checking, repack shall

Re: [PATCH] repack: Add --version parameter

2013-09-26 Thread Duy Nguyen
On Thu, Sep 26, 2013 at 3:32 PM, Stefan Beller stefanbel...@googlemail.com wrote: This is just a direct translation of http://article.gmane.org/gmane.comp.version-control.git/235396 So I don't consider this is ready for inclusion. Some notes: We need to have more error checking, repack shall