Re: [PATCH] rev-parse: fix --resolve-git-dir argument handling

2014-02-19 Thread John Keeping
On Tue, Feb 18, 2014 at 04:25:37PM -0800, Junio C Hamano wrote: Junio C Hamano gits...@pobox.com writes: John Keeping j...@keeping.me.uk writes: There are two problems here: 1) If no argument is provided, then the command segfaults 2) The argument is not consumed, so there will be

Re: [PATCH] rev-parse: fix --resolve-git-dir argument handling

2014-02-18 Thread Junio C Hamano
John Keeping j...@keeping.me.uk writes: There are two problems here: 1) If no argument is provided, then the command segfaults 2) The argument is not consumed, so there will be excess output Fix both of these in one go by restructuring the handler for this option. Reported-by: Daniel

Re: [PATCH] rev-parse: fix --resolve-git-dir argument handling

2014-02-18 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: John Keeping j...@keeping.me.uk writes: There are two problems here: 1) If no argument is provided, then the command segfaults 2) The argument is not consumed, so there will be excess output Fix both of these in one go by restructuring the handler

[PATCH] rev-parse: fix --resolve-git-dir argument handling

2014-02-17 Thread John Keeping
There are two problems here: 1) If no argument is provided, then the command segfaults 2) The argument is not consumed, so there will be excess output Fix both of these in one go by restructuring the handler for this option. Reported-by: Daniel Hahler genml+git-2...@thequod.de Signed-off-by: