[PATCH] revision.c: Fix a sparse warning

2013-07-27 Thread Ramsay Jones
Sparse issues an "symbol 'saved_parents_slab' was not declared. Should it be static?" warning. In order to suppress the warning, since this symbol does not require more than file visibility, we simply add the static modifier to its declaration. Signed-off-by: Ramsay Jones --- Hi Thomas, In add

Re: [PATCH] revision.c: Fix a sparse warning

2013-05-06 Thread Junio C Hamano
Kevin Bracey writes: > On 04/05/2013 20:25, Ramsay Jones wrote: >> Sparse issues an "'sole_interesting' not declared. Should it be static?" >> warning. In order to suppress the warning, since this symbol does not >> need more than file visibility, we simply add the static modifier to >> its decla

Re: [PATCH] revision.c: Fix a sparse warning

2013-05-04 Thread Kevin Bracey
On 04/05/2013 20:25, Ramsay Jones wrote: Sparse issues an "'sole_interesting' not declared. Should it be static?" warning. In order to suppress the warning, since this symbol does not need more than file visibility, we simply add the static modifier to its declaration. Thanks! I'll include tha

[PATCH] revision.c: Fix a sparse warning

2013-05-04 Thread Ramsay Jones
Sparse issues an "'sole_interesting' not declared. Should it be static?" warning. In order to suppress the warning, since this symbol does not need more than file visibility, we simply add the static modifier to its declaration. Signed-off-by: Ramsay Jones --- Hi Kevin, If you need to re-roll