Re: [PATCH] run-command: fix build on cygwin (stdin is a macro)

Hi, On Thu, 6 Oct 2016, Torsten Bögershausen wrote: > >I am not suggesting that you apply this exact patch (stdin_ is not a good > choice > > How about fd_stdin ? Better: stdin_fd. Why? Prior art: $ git grep -c stdin_fd builtin/remote-ext.c:3 $ git grep -c fd_stdin

Re: [PATCH] run-command: fix build on cygwin (stdin is a macro)

>I am not suggesting that you apply this exact patch (stdin_ is not a good choice How about fd_stdin ?

[PATCH] run-command: fix build on cygwin (stdin is a macro)

Signed-off-by: Ramsay Jones --- Hi Lars, Commit 6007c69e ("run-command: add wait_on_exit", 04-10-2016), which is part of your 'ls/filter-process' branch, causes the build to fail on cygwin, since 'stdin' is defined as a macro thus: #define stdin