[PATCH] send-email: error out when relogin delay is missing

When the batch size is neither configured nor given on the command line, but the relogin delay is given, then the current code ignores the relogin delay setting. This is unsafe as there was some intention when setting the batch size. One workaround would be to just assume a batch size of 1 as a

Re: [PATCH] send-email: error out when relogin delay is missing

On Thu, Feb 8, 2018 at 1:21 PM, Stefan Beller wrote: > On Thu, Feb 8, 2018 at 12:08 AM, Eric Sunshine > wrote: >> On Wed, Feb 7, 2018 at 6:43 PM, Stefan Beller wrote: >>> +die __("When a batch size is given, the relogin delay

Re: [PATCH] send-email: error out when relogin delay is missing

On Thu, Feb 8, 2018 at 12:08 AM, Eric Sunshine wrote: > On Wed, Feb 7, 2018 at 6:43 PM, Stefan Beller wrote: >> [...] >> Error out for now instead of potentially confusing the user. >> As 5453b83bdf (send-email: --batch-size to work around some SMTP

Re: [PATCH] send-email: error out when relogin delay is missing

On Wed, Feb 7, 2018 at 6:43 PM, Stefan Beller wrote: > [...] > Error out for now instead of potentially confusing the user. > As 5453b83bdf (send-email: --batch-size to work around some SMTP > server limit, 2017-05-21) lays out, we rather want to not have this > interface

Re: [PATCH] send-email: error out when relogin delay is missing

> 在 2018年2月8日，上午7:43，Stefan Beller 写道： > > +die __("When a batch size is given, the relogin delay must be set\n") > +if defined $relogin_delay and not defined $batch_size; > + According the code, maybe you want to say “When relogin delay is given, a batch size must be

[PATCH] send-email: error out when relogin delay is missing

When the batch size is neither configured nor given on the command line, but the relogin delay is given, then the current code ignores the relogin delay setting. This is unsafe as there was some intention when setting the batch size. One workaround would be to just assume a batch size of 1 as a