Re: Re* [PATCH] send-email: recognize absolute path on Windows

2014-04-15 Thread Junio C Hamano
Erik Faye-Lund writes: > ... But, ugh. > Modifying File::Spec into thinking msys is Win32 doesn't seems to > work, OK, I'll drop the tentative version and wait for a proper reroll. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel

Re: Re* [PATCH] send-email: recognize absolute path on Windows

2014-04-15 Thread Erik Faye-Lund
On Tue, Apr 15, 2014 at 10:37 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Thanks, both. I'd expect another round then? >> >> -- >8 -- >> From: Erik Faye-Lund >> >> On Windows, absolute paths might start with a DOS drive prefix, >> which these checks fail to recognize. >> >> Use file

Re: Re* [PATCH] send-email: recognize absolute path on Windows

2014-04-15 Thread Junio C Hamano
Junio C Hamano writes: > Thanks, both. I'd expect another round then? > > -- >8 -- > From: Erik Faye-Lund > > On Windows, absolute paths might start with a DOS drive prefix, > which these checks fail to recognize. > > Use file_name_is_absolute from File::Spec::Functions for > portability. The

Re: [PATCH] send-email: recognize absolute path on Windows

2014-04-15 Thread Erik Faye-Lund
On Tue, Apr 15, 2014 at 12:42 PM, Erik Faye-Lund wrote: > On Tue, Apr 15, 2014 at 12:32 PM, Johannes Sixt wrote: >> Am 4/15/2014 10:44, schrieb Erik Faye-Lund: >>> From: Erik Faye-Lund >>> >>> On Windows, absolute paths might start with a DOS drive prefix, >>> which this check fails to recognize

Re* [PATCH] send-email: recognize absolute path on Windows

2014-04-15 Thread Junio C Hamano
Erik Faye-Lund writes: >>> Here's a patch that we've been running with a variation of in >>> Git for Windows for a while. That version wasn't quite palatable, >>> as it recognized DOS drive-prefixes on all platforms. >> >> Did you consider patching msysgit's lib/perl5/5.8.8/File/Spec.pm by >> ins

Re: [PATCH] send-email: recognize absolute path on Windows

2014-04-15 Thread Erik Faye-Lund
On Tue, Apr 15, 2014 at 12:32 PM, Johannes Sixt wrote: > Am 4/15/2014 10:44, schrieb Erik Faye-Lund: >> From: Erik Faye-Lund >> >> On Windows, absolute paths might start with a DOS drive prefix, >> which this check fails to recognize. >> >> Unfortunately, we cannot simply use the file_name_is_abs

Re: [PATCH] send-email: recognize absolute path on Windows

2014-04-15 Thread Johannes Sixt
Am 4/15/2014 10:44, schrieb Erik Faye-Lund: > From: Erik Faye-Lund > > On Windows, absolute paths might start with a DOS drive prefix, > which this check fails to recognize. > > Unfortunately, we cannot simply use the file_name_is_absolute > helper in File::Spec::Functions, because Git for Windo

[PATCH] send-email: recognize absolute path on Windows

2014-04-15 Thread Erik Faye-Lund
From: Erik Faye-Lund On Windows, absolute paths might start with a DOS drive prefix, which this check fails to recognize. Unfortunately, we cannot simply use the file_name_is_absolute helper in File::Spec::Functions, because Git for Windows has an MSYS-based Perl, where this helper doesn't grok