On Tue, Jan 07, 2014 at 12:31:57PM -0800, Junio C Hamano wrote:
> > c. Just leave it at Brodie's patch with nothing else on top.
> >
> > My thinking in favor of (b) was basically "does anybody actually care
> > about ambiguous refs in this situation anyway?". If they do, then I
> > think (c) is
Jeff King writes:
> On Tue, Jan 07, 2014 at 11:38:15AM -0800, Junio C Hamano wrote:
>
>> >> > Alternatively, I guess "cat-file
>> >> > --batch" could just turn off warn_ambiguous_refs itself.
>> >>
>> >> Sounds like a sensible way to go, perhaps on top of this change?
>> >
>> > The downside is t
On Tue, Jan 07, 2014 at 11:38:15AM -0800, Junio C Hamano wrote:
> >> > Alternatively, I guess "cat-file
> >> > --batch" could just turn off warn_ambiguous_refs itself.
> >>
> >> Sounds like a sensible way to go, perhaps on top of this change?
> >
> > The downside is that we would not warn about a
Jeff King writes:
> On Tue, Jan 07, 2014 at 09:51:07AM -0800, Junio C Hamano wrote:
>
>> Jeff King writes:
>>
>> > Alternatively, I guess "cat-file
>> > --batch" could just turn off warn_ambiguous_refs itself.
>>
>> Sounds like a sensible way to go, perhaps on top of this change?
>
> The downs
This change ensures get_sha1_basic() doesn't try to resolve full hashes
as refs when ambiguous ref warnings are disabled.
This provides a substantial performance improvement when passing many
hashes to a command (like "git rev-list --stdin") when
core.warnambiguousrefs is false. The check incurs 6
On Tue, Jan 07, 2014 at 09:51:07AM -0800, Junio C Hamano wrote:
> Jeff King writes:
>
> > Alternatively, I guess "cat-file
> > --batch" could just turn off warn_ambiguous_refs itself.
>
> Sounds like a sensible way to go, perhaps on top of this change?
The downside is that we would not warn ab
Jeff King writes:
> Alternatively, I guess "cat-file
> --batch" could just turn off warn_ambiguous_refs itself.
Sounds like a sensible way to go, perhaps on top of this change?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
Brodie Rao writes:
> This change ensures get_sha1_basic() doesn't try to resolve full hashes
> as refs when ambiguous ref warnings are disabled.
>
> This provides a substantial performance improvement when passing many
> hashes to a command (like "git rev-list --stdin") when
> core.warnambiguousr
On Mon, Jan 06, 2014 at 07:35:04PM -0800, Brodie Rao wrote:
> On Mon, Jan 6, 2014 at 7:32 PM, Brodie Rao wrote:
> > This change ensures get_sha1_basic() doesn't try to resolve full hashes
> > as refs when ambiguous ref warnings are disabled.
> >
> > This provides a substantial performance improve
On Tue, Jan 7, 2014 at 10:32 AM, Brodie Rao wrote:
> This change ensures get_sha1_basic() doesn't try to resolve full hashes
> as refs when ambiguous ref warnings are disabled.
>
> This provides a substantial performance improvement when passing many
> hashes to a command (like "git rev-list --std
On Mon, Jan 6, 2014 at 7:32 PM, Brodie Rao wrote:
> This change ensures get_sha1_basic() doesn't try to resolve full hashes
> as refs when ambiguous ref warnings are disabled.
>
> This provides a substantial performance improvement when passing many
> hashes to a command (like "git rev-list --stdi
This change ensures get_sha1_basic() doesn't try to resolve full hashes
as refs when ambiguous ref warnings are disabled.
This provides a substantial performance improvement when passing many
hashes to a command (like "git rev-list --stdin") when
core.warnambiguousrefs is false. The check incurs 6
12 matches
Mail list logo
