Re: [PATCH] submodule-parallel-fetch: make some file local symbols static

2015-10-02 Thread Junio C Hamano
Ramsay Jones writes: >> I thought I had this in yesterdays reroll (v6). Oh you're referring to >> the version >> from the 28th (I forgot to label them v5 I suppose). > > Ah! I thought I'd seen it on the list. (I thought I was going crazy) ;-) > Sorry, my fault. I

[PATCH] submodule-parallel-fetch: make some file local symbols static

2015-10-01 Thread Ramsay Jones
Commits 0fc1fdb0 ("fetch_populated_submodules: use new parallel job processing", 28-09-2015) and 60f24f52 ("run-command: add an asynchronous parallel child processor", 28-09-2015) both introduce external symbols which only require file scope visibility. In order to reduce the visibility, apply

Re: [PATCH] submodule-parallel-fetch: make some file local symbols static

2015-10-01 Thread Stefan Beller
On Thu, Oct 1, 2015 at 5:02 AM, Ramsay Jones wrote: > > Commits 0fc1fdb0 ("fetch_populated_submodules: use new parallel job > processing", 28-09-2015) and 60f24f52 ("run-command: add an asynchronous > parallel child processor", 28-09-2015) both introduce external

Re: [PATCH] submodule-parallel-fetch: make some file local symbols static

2015-10-01 Thread Ramsay Jones
On 01/10/15 18:05, Stefan Beller wrote: > On Thu, Oct 1, 2015 at 5:02 AM, Ramsay Jones > wrote: >> [snip] >> diff --git a/run-command.c b/run-command.c >> index 341b23b..347d22e 100644 >> --- a/run-command.c >> +++ b/run-command.c >> @@ -865,7 +865,7 @@ int

[PATCH] submodule-parallel-fetch: make some file local symbols static

2015-09-25 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Stefan, When you next re-roll the patches for your 'sb/submodule-parallel-fetch' branch, could you please squash parts of this into the relevant patches. [which would correspond to commits a93fb7a ("run-command: add an

Re: [PATCH] submodule-parallel-fetch: make some file local symbols static

2015-09-25 Thread Jacob Keller
On Fri, Sep 25, 2015 at 8:15 AM, Ramsay Jones wrote: > [Note these issues were spotted by sparse and static-check.pl] Any chance you got a link to docs about static-check.pl? I've never heard of this... Regards, Jake -- To unsubscribe from this list: send the line