Re: [PATCH] t/t5534: do not unset GIT_COMMITTER_EMAIL for other tests

2018-07-20 Thread Henning Schild
Am Thu, 19 Jul 2018 15:27:56 -0700 schrieb Junio C Hamano : > Henning Schild writes: > > > Looking at "what is cooking" i assume i should not add/fold this > > to/in the serien anymore. So it comes as a separate patch on top. > > Thanks. I only said: > > I think this round is mostly re

Re: [PATCH] t/t5534: do not unset GIT_COMMITTER_EMAIL for other tests

2018-07-19 Thread Junio C Hamano
Henning Schild writes: > Looking at "what is cooking" i assume i should not add/fold this to/in > the serien anymore. So it comes as a separate patch on top. Thanks. I only said: I think this round is mostly ready, except for a minor nit in the last step. I do not mind merging this

Re: [PATCH] t/t5534: do not unset GIT_COMMITTER_EMAIL for other tests

2018-07-19 Thread Taylor Blau
On Thu, Jul 19, 2018 at 02:14:09PM +0200, Henning Schild wrote: > Unsetting the varibale for good can have unwanted effects for new s/varibale/variable > tests added in the future It also meant we needed to hardcode the s/future/&. > value for "user.signingkey". > Move the unset into a subshell

Re: [PATCH] t/t5534: do not unset GIT_COMMITTER_EMAIL for other tests

2018-07-19 Thread Henning Schild
Looking at "what is cooking" i assume i should not add/fold this to/in the serien anymore. So it comes as a separate patch on top. Henning Am Thu, 19 Jul 2018 14:14:09 +0200 schrieb Henning Schild : > Unsetting the varibale for good can have unwanted effects for new > tests added in the future I

[PATCH] t/t5534: do not unset GIT_COMMITTER_EMAIL for other tests

2018-07-19 Thread Henning Schild
Unsetting the varibale for good can have unwanted effects for new tests added in the future It also meant we needed to hardcode the value for "user.signingkey". Move the unset into a subshell, get rid of the hardcoded "commit...@example.com", and switch the GPG variant to using test_config just lik