Re: [PATCH] t/t5800-remote-testpy: skip all tests if not built

2013-06-21 Thread Ramkumar Ramachandra
Jeff King wrote: So I do not see any problem with the current Makefile. Running make or make test should let t5800 pass. Can you describe how you are triggering the issue in more detail? master, at the time of reporting the issue: artagnon|master=:~/src/git$ make -j 8

Re: [PATCH] t/t5800-remote-testpy: skip all tests if not built

2013-06-21 Thread Jeff King
On Fri, Jun 21, 2013 at 12:07:50PM +0530, Ramkumar Ramachandra wrote: Yesterday's jc publish fixed it: 6c473a5 (build: generate and clean test scripts, 2013-06-07) graduated to master; it adds $NO_INSTALL to the target all, among other things. Ah, makes sense. Sorry to be slow. -Peff -- To

Re: [PATCH] t/t5800-remote-testpy: skip all tests if not built

2013-06-20 Thread Jeff King
On Wed, Jun 19, 2013 at 02:05:06AM +0530, Ramkumar Ramachandra wrote: Junio C Hamano wrote: Sounds like making make test build it is a more correct approach, at least to me. What am I missing? How exactly? I'm not exactly competent in make, but this is what I understood from what you

Re: [PATCH] t/t5800-remote-testpy: skip all tests if not built

2013-06-18 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: What this means is that git-remote-testpy is not built by default (when 'make' is invoked), but t5800 runs by default (like every other test in t/). As a result, a new contributor cloning git.git and running 'make test' for the first time will

Re: [PATCH] t/t5800-remote-testpy: skip all tests if not built

2013-06-18 Thread Ramkumar Ramachandra
Junio C Hamano wrote: Sounds like making make test build it is a more correct approach, at least to me. What am I missing? How exactly? I'm not exactly competent in make, but this is what I understood from what you said (and it's obviously wrong): diff --git a/Makefile b/Makefile index