Re: [PATCH] t7508: avoid non-portable sed expression

2013-09-14 Thread Matthieu Moy
Eric Sunshine writes: > strip_comments () { > - sed "s/^\# //; s/^\#$//; s/^#\t/\t/" <"$1" >"$1".tmp && > + tab=' ' > + sed "s/^\# //; s/^\#$//; s/^#$tab/$tab/" <"$1" >"$1".tmp && Sounds trivially right. Sorry for breaking this. -- Matthieu Moy http://www-verimag.imag.fr/~moy/

[PATCH] t7508: avoid non-portable sed expression

2013-09-13 Thread Eric Sunshine
2556b996 (status: disable display of '#' comment prefix by default; 2013-09-06) introduced tests which fail on Mac OS X due to unportable use of \t (for TAB) in a sed expression. POSIX [1][2] also disallows it. Fix this. [1]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html#tag_