Re: [PATCH] t8008: rely on rev-parse'd HEAD instead of sha1 value

2017-07-18 Thread Junio C Hamano
Stefan Beller writes: > On Tue, Jul 18, 2017 at 12:17 PM, Junio C Hamano wrote: >> Stefan Beller writes: >> >>> Remove hard coded sha1 values, obtain the values using 'git rev-parse HEAD' >>> which should be future proof regardless of

Re: [PATCH] t8008: rely on rev-parse'd HEAD instead of sha1 value

2017-07-18 Thread Stefan Beller
On Tue, Jul 18, 2017 at 12:17 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Remove hard coded sha1 values, obtain the values using 'git rev-parse HEAD' >> which should be future proof regardless of the hash function used. > > Don't hardcoded

Re: [PATCH] t8008: rely on rev-parse'd HEAD instead of sha1 value

2017-07-18 Thread Junio C Hamano
Stefan Beller writes: > Remove hard coded sha1 values, obtain the values using 'git rev-parse HEAD' > which should be future proof regardless of the hash function used. Don't hardcoded lengths of the hashes defeat this future-proofing effort, though? It shouldn't be too

[PATCH] t8008: rely on rev-parse'd HEAD instead of sha1 value

2017-07-17 Thread Stefan Beller
Remove hard coded sha1 values, obtain the values using 'git rev-parse HEAD' which should be future proof regardless of the hash function used. Signed-off-by: Stefan Beller --- t/t8008-blame-formats.sh | 28 +++- 1 file changed, 15 insertions(+), 13