Re: [PATCH] test-lib.sh - define and use GREP_STRIPS_CR

[Junio C Hamano]

Ramsay Jones ram...@ramsay1.demon.co.uk writes:

 Mark Levedahl wrote:
 Define a common macro for grep needing -U to allow tests to not need
 to inquire of specific platforms needing this option. Change
 t3032 and t5560 to use this rather than testing explicitly for mingw.
 This fixes these two tests on Cygwin.
 
 Signed-off-by: Mark Levedahl mleved...@gmail.com
 ---
 This replaces my earlier patch against t3032 (8896b287 on pu)

 Yep, this looks good and (as expected) it works on cygwin 1.5 too. :-D

 Thanks.

After this patch lands 'master', we may want to add a note to these
SED/GREP workarounds for CRLF platforms that we assume the platform
use GNU sed/grep.

Incidentally, don't we also need unset SED_OPTIONS in
t/test-lib.sh net to where we unset GREP_OPTIONS?

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] test-lib.sh - define and use GREP_STRIPS_CR

[Ramsay Jones]

Mark Levedahl wrote:
 Define a common macro for grep needing -U to allow tests to not need
 to inquire of specific platforms needing this option. Change
 t3032 and t5560 to use this rather than testing explicitly for mingw.
 This fixes these two tests on Cygwin.
 
 Signed-off-by: Mark Levedahl mleved...@gmail.com
 ---
 This replaces my earlier patch against t3032 (8896b287 on pu)

Yep, this looks good and (as expected) it works on cygwin 1.5 too. :-D

Thanks.

ATB,
Ramsay Jones



--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] test-lib.sh - define and use GREP_STRIPS_CR

[Mark Levedahl]

Define a common macro for grep needing -U to allow tests to not need
to inquire of specific platforms needing this option. Change
t3032 and t5560 to use this rather than testing explicitly for mingw.
This fixes these two tests on Cygwin.

Signed-off-by: Mark Levedahl mleved...@gmail.com
---
This replaces my earlier patch against t3032 (8896b287 on pu)

 t/t3032-merge-recursive-options.sh | 2 +-
 t/t5560-http-backend-noserver.sh   | 2 +-
 t/test-lib.sh  | 2 ++
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/t/t3032-merge-recursive-options.sh 
b/t/t3032-merge-recursive-options.sh
index 2b17311..5fd7bbb 100755
--- a/t/t3032-merge-recursive-options.sh
+++ b/t/t3032-merge-recursive-options.sh
@@ -14,7 +14,7 @@ test_description='merge-recursive options
 . ./test-lib.sh
 
 test_have_prereq SED_STRIPS_CR  SED_OPTIONS=-b
-test_have_prereq MINGW  export GREP_OPTIONS=-U
+test_have_prereq GREP_STRIPS_CR  export GREP_OPTIONS=-U
 
 test_expect_success 'setup' '
conflict_hunks () {
diff --git a/t/t5560-http-backend-noserver.sh b/t/t5560-http-backend-noserver.sh
index ef98d95..9be9ae3 100755
--- a/t/t5560-http-backend-noserver.sh
+++ b/t/t5560-http-backend-noserver.sh
@@ -5,7 +5,7 @@ test_description='test git-http-backend-noserver'
 
 HTTPD_DOCUMENT_ROOT_PATH=$TRASH_DIRECTORY
 
-test_have_prereq MINGW  export GREP_OPTIONS=-U
+test_have_prereq GREP_STRIPS_CR  export GREP_OPTIONS=-U
 
 run_backend() {
echo $2 |
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 2d63307..1abea40 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -824,6 +824,7 @@ case $(uname -s) in
test_set_prereq MINGW
test_set_prereq NOT_CYGWIN
test_set_prereq SED_STRIPS_CR
+   test_set_prereq GREP_STRIPS_CR
;;
 *CYGWIN*)
test_set_prereq POSIXPERM
@@ -831,6 +832,7 @@ case $(uname -s) in
test_set_prereq NOT_MINGW
test_set_prereq CYGWIN
test_set_prereq SED_STRIPS_CR
+   test_set_prereq GREP_STRIPS_CR
;;
 *)
test_set_prereq POSIXPERM
-- 
1.8.3.2.0.13

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html