Re: [PATCH] write_index: optionally allow broken null sha1s

2013-08-25 Thread Jonathan Nieder
Hi, Jeff King wrote: --- I was tempted to not involve filter-branch in this commit at all, and instead require the user to manually invoke GIT_ALLOW_NULL_SHA1=1 git filter-branch ... to perform such a filter. That would be slightly safer, but requires some specialized knowledge from

[PATCH] write_index: optionally allow broken null sha1s

2013-08-23 Thread Jeff King
Commit 4337b58 (do not write null sha1s to on-disk index, 2012-07-28) unconditionally prevents git from writing null sha1s into the index. The intent was to catch errors in other parts of the code that might let such an entry slip into the index (or worse, a tree). However, some repositories have