Re: [PATCH 0/2] Fix regression: CamelCased aliases

2017-07-14 Thread Junio C Hamano
Jeff King writes: >> There is also this: >> >> $ git branch >> * master >> $ git BRANCH >> git: 'BRANCH' is not a git command. See 'git --help'. >> $ git config alias.branch 'branch -v' >> $ git branch >> * master >> $ git BRANCH >> * master 51c785c initial > >

Re: [PATCH 0/2] Fix regression: CamelCased aliases

2017-07-14 Thread Jeff King
On Fri, Jul 14, 2017 at 05:26:00PM +, astian wrote: > FWIW, I don't like 2, I don't like the irregularity in the invocation: Without quoting, it took me a second to figure out what you meant. But I think "2" here is the "mental model 2" I mentioned in my earlier email. > $ git branch >

Re: [PATCH 0/2] Fix regression: CamelCased aliases

2017-07-14 Thread astian
FWIW, I don't like 2, I don't like the irregularity in the invocation: $ git branch * master $ git BRANCH git: 'BRANCH' is not a git command. See 'git --help'. $ git config alias.br 'branch -v' $ git br * master 51c785c initial $ git BR * master 51c785c initial There is also

Re: [PATCH 0/2] Fix regression: CamelCased aliases

2017-07-14 Thread Junio C Hamano
Jeff King writes: > I think there are basically two mental models that are reasonable: > > 1. Uppercase in key names is treated the same as lowercase. Therefore > we must allow "alias.Foo" to match "git foo", but "git Foo" can > never have a match (in the current

Re: [PATCH 0/2] Fix regression: CamelCased aliases

2017-07-14 Thread Jeff King
On Fri, Jul 14, 2017 at 08:14:18AM -0700, Junio C Hamano wrote: > >> It was possible before v2.13.3 to invoke: > >> > >>git config alias.CamelCased > >>git CamelCased > >> > >> This regressed (due to a stupid mistake of mine that was not caught in > >> patch review, sadly) in v2.13.3.

Re: [PATCH 0/2] Fix regression: CamelCased aliases

2017-07-14 Thread Junio C Hamano
Jeff King writes: > On Fri, Jul 14, 2017 at 10:39:24AM +0200, Johannes Schindelin wrote: > >> It was possible before v2.13.3 to invoke: >> >> git config alias.CamelCased >> git CamelCased >> >> This regressed (due to a stupid mistake of mine that was not caught in >>

Re: [PATCH 0/2] Fix regression: CamelCased aliases

2017-07-14 Thread Jeff King
On Fri, Jul 14, 2017 at 10:39:24AM +0200, Johannes Schindelin wrote: > It was possible before v2.13.3 to invoke: > > git config alias.CamelCased > git CamelCased > > This regressed (due to a stupid mistake of mine that was not caught in > patch review, sadly) in v2.13.3.

[PATCH 0/2] Fix regression: CamelCased aliases

2017-07-14 Thread Johannes Schindelin
It was possible before v2.13.3 to invoke: git config alias.CamelCased git CamelCased This regressed (due to a stupid mistake of mine that was not caught in patch review, sadly) in v2.13.3. And this patch series fixes it again, introducing a regression test to ensure that it