Re: [PATCH 0/9] worktree: fix bugs and broaden --force applicability

2018-08-31 Thread Ramsay Jones
On 31/08/18 01:54, Jeff King wrote: > On Fri, Aug 31, 2018 at 12:49:39AM +0100, Ramsay Jones wrote: > >> On 30/08/18 21:14, Junio C Hamano wrote: >>> Jeff King writes: >>> I suppose so. I don't think I've _ever_ used distclean, and I only rarely use "clean" (a testament to our

Re: [PATCH 0/9] worktree: fix bugs and broaden --force applicability

2018-08-30 Thread Jeff King
On Fri, Aug 31, 2018 at 12:49:39AM +0100, Ramsay Jones wrote: > On 30/08/18 21:14, Junio C Hamano wrote: > > Jeff King writes: > > > >> I suppose so. I don't think I've _ever_ used distclean, and I only > >> rarely use "clean" (a testament to our Makefile's efforts to accurately > >> track

Re: [PATCH 0/9] worktree: fix bugs and broaden --force applicability

2018-08-30 Thread Ramsay Jones
On 30/08/18 21:14, Junio C Hamano wrote: > Jeff King writes: > >> I suppose so. I don't think I've _ever_ used distclean, and I only >> rarely use "clean" (a testament to our Makefile's efforts to accurately >> track dependencies). I'd usually use "git clean" when I want something >> pristine

Re: [PATCH 0/9] worktree: fix bugs and broaden --force applicability

2018-08-30 Thread Junio C Hamano
Jeff King writes: > I suppose so. I don't think I've _ever_ used distclean, and I only > rarely use "clean" (a testament to our Makefile's efforts to accurately > track dependencies). I'd usually use "git clean" when I want something > pristine (because I don't want to trust the Makefile at

Re: [PATCH 0/9] worktree: fix bugs and broaden --force applicability

2018-08-30 Thread Jeff King
On Thu, Aug 30, 2018 at 05:04:32AM -0400, Eric Sunshine wrote: > On Thu, Aug 30, 2018 at 3:54 AM Jeff King wrote: > > Subject: [PATCH] doc-diff: force worktree add > > > > We avoid re-creating our temporary worktree if it's already > > there. But we may run into a situation where the worktree >

Re: [PATCH 0/9] worktree: fix bugs and broaden --force applicability

2018-08-30 Thread Eric Sunshine
On Thu, Aug 30, 2018 at 3:54 AM Jeff King wrote: > Subject: [PATCH] doc-diff: force worktree add > > We avoid re-creating our temporary worktree if it's already > there. But we may run into a situation where the worktree > has been deleted, but an entry still exists in > $GIT_DIR/worktrees. Can

Re: [PATCH 0/9] worktree: fix bugs and broaden --force applicability

2018-08-30 Thread Eric Sunshine
On Thu, Aug 30, 2018 at 3:54 AM Jeff King wrote: > On Tue, Aug 28, 2018 at 05:20:17PM -0400, Eric Sunshine wrote: > > This series started as a fix for a bug reported by Peff[1] in which the > > "database" of worktrees could be corrupted (or at least become > > internally inconsistent) by having

Re: [PATCH 0/9] worktree: fix bugs and broaden --force applicability

2018-08-30 Thread Jeff King
On Tue, Aug 28, 2018 at 05:20:17PM -0400, Eric Sunshine wrote: > This series started as a fix for a bug reported by Peff[1] in which the > "database" of worktrees could be corrupted (or at least become > internally inconsistent) by having multiple worktree entries associated > with the same path.

[PATCH 0/9] worktree: fix bugs and broaden --force applicability

2018-08-28 Thread Eric Sunshine
This series started as a fix for a bug reported by Peff[1] in which the "database" of worktrees could be corrupted (or at least become internally inconsistent) by having multiple worktree entries associated with the same path. Peff's particular use-case for git-worktree is Documentation/doc-diff