Re: [PATCH 00/12] Integrate commit-graph into fsck, gc, and fetch

On 11 May 2018 at 19:23, Derrick Stolee wrote: > Martin's initial test cases are wonderful. I've adapted them to test the > other conditions in the verify_commit_graph() method and caught some > interesting behavior in the process. I'm preparing v2 so we can investigate > the

Re: [PATCH 00/12] Integrate commit-graph into fsck, gc, and fetch

On 5/10/2018 3:22 PM, Stefan Beller wrote: On Thu, May 10, 2018 at 12:05 PM, Martin Ågren wrote: On 10 May 2018 at 19:34, Derrick Stolee wrote: Commits 01-07 focus on the 'git commit-graph verify' subcommand. These are ready for full, rigorous

Re: [PATCH 00/12] Integrate commit-graph into fsck, gc, and fetch

On 5/10/2018 3:17 PM, Ævar Arnfjörð Bjarmason wrote: On Thu, May 10 2018, Derrick Stolee wrote: The behavior in this patch series does the following: 1. Near the end of 'git gc', run 'git commit-graph write'. The location of this code assumes that a 'git gc --auto' has not terminated

Re: [PATCH 00/12] Integrate commit-graph into fsck, gc, and fetch

On 5/10/2018 4:45 PM, Martin Ågren wrote: On 10 May 2018 at 21:22, Stefan Beller wrote: On Thu, May 10, 2018 at 12:05 PM, Martin Ågren wrote: I hope to find time to do some more hands-on testing of this to see that errors actually do get caught.

Re: [PATCH 00/12] Integrate commit-graph into fsck, gc, and fetch

On 10 May 2018 at 21:22, Stefan Beller wrote: > On Thu, May 10, 2018 at 12:05 PM, Martin Ågren wrote: >> I hope to find time to do some more hands-on testing of this to see that >> errors actually do get caught. > Packfiles and loose objects are

Re: [PATCH 00/12] Integrate commit-graph into fsck, gc, and fetch

On Thu, May 10, 2018 at 12:05 PM, Martin Ågren wrote: > On 10 May 2018 at 19:34, Derrick Stolee wrote: > >> Commits 01-07 focus on the 'git commit-graph verify' subcommand. These >> are ready for full, rigorous review. > > I don't know about "full"

Re: [PATCH 00/12] Integrate commit-graph into fsck, gc, and fetch

On Thu, May 10 2018, Derrick Stolee wrote: > The behavior in this patch series does the following: > > 1. Near the end of 'git gc', run 'git commit-graph write'. The location >of this code assumes that a 'git gc --auto' has not terminated early >due to not meeting the auto threshold. > >

Re: [PATCH 00/12] Integrate commit-graph into fsck, gc, and fetch

On 10 May 2018 at 19:34, Derrick Stolee wrote: > Commits 01-07 focus on the 'git commit-graph verify' subcommand. These > are ready for full, rigorous review. I don't know about "full" and "rigorous", but I tried to offer my thoughts. A lingering feeling I have is that

[PATCH 00/12] Integrate commit-graph into fsck, gc, and fetch

The commit-graph feature is not useful to end users until the commit-graph file is maintained automatically by Git during normal upkeep operations. One natural place to trigger this write is during 'git gc'. Before automatically generating a commit-graph, we need to be able to verify the contents