Re: [PATCH 00/17] Clean up how fetch_pack() handles the heads list

2012-09-02 Thread Michael Haggerty
On 08/23/2012 10:31 PM, Jeff King wrote: On Thu, Aug 23, 2012 at 03:56:48PM -0400, Jeff King wrote: This code blames back to: commit 4bcb310c2539b66d535e87508d1b7a90fe29c083 Author: Alexandre Julliard julli...@winehq.org Date: Fri Nov 24 16:00:13 2006 +0100 fetch-pack: Do not

Re: [PATCH 00/17] Clean up how fetch_pack() handles the heads list

2012-08-25 Thread Michael Haggerty
On 08/23/2012 10:31 PM, Jeff King wrote: I think part of the confusion of this code is that inside the loop over the refs it is sometimes checking aspects of the ref, and sometimes checking invariants of the loop (like args.fetch_all). Splitting it into separate loops makes it easier to see

Re: [PATCH 00/17] Clean up how fetch_pack() handles the heads list

2012-08-24 Thread Philip Oakley
From: Junio C Hamano gits...@pobox.com Sent: Friday, August 24, 2012 5:23 AM Jeff King p...@peff.net writes: It may be (?) that it is a good time to think about a 'datedepth' capability to bypass the current counted-depth shallow fetch that can cause so much trouble. With a date limited

[PATCH 00/17] Clean up how fetch_pack() handles the heads list

2012-08-23 Thread mhagger
From: Michael Haggerty mhag...@alum.mit.edu There were various confusing things (and a couple of bugs) in the way that fetch_pack() handled the list (nr_heads, heads) of references to be sought from the remote: * Different names were used for the list in different functions for no special

Re: [PATCH 00/17] Clean up how fetch_pack() handles the heads list

2012-08-23 Thread Jeff King
On Thu, Aug 23, 2012 at 10:10:25AM +0200, mhag...@alum.mit.edu wrote: There were various confusing things (and a couple of bugs) in the way that fetch_pack() handled the list (nr_heads, heads) of references to be sought from the remote: Aside from the minor comments I made to individual

Re: [PATCH 00/17] Clean up how fetch_pack() handles the heads list

2012-08-23 Thread Philip Oakley
From: Jeff King p...@peff.net Sent: Thursday, August 23, 2012 10:26 AM On Thu, Aug 23, 2012 at 10:10:25AM +0200, mhag...@alum.mit.edu wrote: There were various confusing things (and a couple of bugs) in the way that fetch_pack() handled the list (nr_heads, heads) of references to be sought

Re: [PATCH 00/17] Clean up how fetch_pack() handles the heads list

2012-08-23 Thread Jeff King
On Thu, Aug 23, 2012 at 08:13:29PM +0100, Philip Oakley wrote: I'm still suspicious about the logic related to args.fetch_all and args.depth, but I don't think I've made anything worse. I think the point of that is that when doing git fetch-pack --all --depth=1, the meaning of --all is

Re: [PATCH 00/17] Clean up how fetch_pack() handles the heads list

2012-08-23 Thread Jeff King
On Thu, Aug 23, 2012 at 03:56:48PM -0400, Jeff King wrote: This code blames back to: commit 4bcb310c2539b66d535e87508d1b7a90fe29c083 Author: Alexandre Julliard julli...@winehq.org Date: Fri Nov 24 16:00:13 2006 +0100 fetch-pack: Do not fetch tags for shallow clones. A

Re: [PATCH 00/17] Clean up how fetch_pack() handles the heads list

2012-08-23 Thread Philip Oakley
From: Jeff King p...@peff.net Sent: Thursday, August 23, 2012 8:56 PM On Thu, Aug 23, 2012 at 08:13:29PM +0100, Philip Oakley wrote: I'm still suspicious about the logic related to args.fetch_all and args.depth, but I don't think I've made anything worse. I think the point of that is that

Re: [PATCH 00/17] Clean up how fetch_pack() handles the heads list

2012-08-23 Thread Junio C Hamano
Jeff King p...@peff.net writes: It may be (?) that it is a good time to think about a 'datedepth' capability to bypass the current counted-depth shallow fetch that can cause so much trouble. With a date limited depth the relevant tags could also be fetched. I don't have anything against