Re: [PATCH 01/10] builtin/commit.c: convert trivial snprintf calls to xsnprintf

2016-06-03 Thread Ramsay Jones
On 03/06/16 09:49, Jeff King wrote: > On Fri, Jun 03, 2016 at 07:47:15AM +, Elia Pinto wrote: > [snip] > For this particular change: > >> diff --git a/builtin/commit.c b/builtin/commit.c >> index 443ff91..c65abaa 100644 >> --- a/builtin/commit.c >> +++ b/builtin/commit.c >> @@ -1552,7

Re: [PATCH 01/10] builtin/commit.c: convert trivial snprintf calls to xsnprintf

2016-06-03 Thread Jeff King
On Fri, Jun 03, 2016 at 04:49:18AM -0400, Jeff King wrote: > I haven't looked carefully at each call site in detail yet, but from the > previous rounds of sprintf handling, I'd guess each site falls into one > of two categories: So that being said, I did just look at several of them. And I think

Re: [PATCH 01/10] builtin/commit.c: convert trivial snprintf calls to xsnprintf

2016-06-03 Thread Jeff King
On Fri, Jun 03, 2016 at 07:47:15AM +, Elia Pinto wrote: > With the commits f2f02675 and 5096d490 we have been converted in some files > the call > from snprintf/sprintf/strcpy to xsnprintf. This patch converts the remaining > calls > to snprintf with xsnprintf under the following

[PATCH 01/10] builtin/commit.c: convert trivial snprintf calls to xsnprintf

2016-06-03 Thread Elia Pinto
With the commits f2f02675 and 5096d490 we have been converted in some files the call from snprintf/sprintf/strcpy to xsnprintf. This patch converts the remaining calls to snprintf with xsnprintf under the following conditions: - The call to snprintf does not control the outcome of the command