Re: [PATCH 01/12] Make starts_with() a wrapper of skip_prefix()

2013-12-18 Thread Junio C Hamano
Junio C Hamano writes: > Nguyễn Thái Ngọc Duy writes: > >> starts_with() started out as a copy of prefixcmp(). But if we don't >> care about the sorting order, the logic looks closer to >> skip_prefix(). This looks like a good thing to do. >> >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- > > S

Re: [PATCH 01/12] Make starts_with() a wrapper of skip_prefix()

2013-12-18 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > starts_with() started out as a copy of prefixcmp(). But if we don't > care about the sorting order, the logic looks closer to > skip_prefix(). This looks like a good thing to do. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- Sure, but the implementation of skip_p

[PATCH 01/12] Make starts_with() a wrapper of skip_prefix()

2013-12-18 Thread Nguyễn Thái Ngọc Duy
starts_with() started out as a copy of prefixcmp(). But if we don't care about the sorting order, the logic looks closer to skip_prefix(). This looks like a good thing to do. Signed-off-by: Nguyễn Thái Ngọc Duy --- git-compat-util.h | 6 +- strbuf.c | 9 - 2 files changed, 5