Re: [PATCH 025/194] object-store: allow prepare_alt_odb to handle arbitrary repositories

2018-02-07 Thread brian m. carlson
On Tue, Feb 06, 2018 at 09:48:56AM -0800, Stefan Beller wrote: > On Mon, Feb 5, 2018 at 5:19 PM, brian m. carlson > wrote: > > On Mon, Feb 05, 2018 at 03:54:46PM -0800, Stefan Beller wrote: > >> @@ -434,12 +433,12 @@ static int link_alt_odb_entry_the_repository(const

Re: [PATCH 025/194] object-store: allow prepare_alt_odb to handle arbitrary repositories

2018-02-07 Thread Jonathan Tan
On Mon, 5 Feb 2018 15:54:46 -0800 Stefan Beller wrote: > + /* > + * Path to the alternate object database, relative to the > + * current working directory. > + */ > char path[FLEX_ARRAY]; I would prefer this to be commented: Path to the

Re: [PATCH 025/194] object-store: allow prepare_alt_odb to handle arbitrary repositories

2018-02-06 Thread Stefan Beller
On Mon, Feb 5, 2018 at 5:19 PM, brian m. carlson wrote: > On Mon, Feb 05, 2018 at 03:54:46PM -0800, Stefan Beller wrote: >> @@ -434,12 +433,12 @@ static int link_alt_odb_entry_the_repository(const >> char *entry, >> ent = alloc_alt_odb(pathbuf.buf); >> >>

Re: [PATCH 025/194] object-store: allow prepare_alt_odb to handle arbitrary repositories

2018-02-06 Thread Derrick Stolee
On 2/5/2018 8:19 PM, brian m. carlson wrote: On Mon, Feb 05, 2018 at 03:54:46PM -0800, Stefan Beller wrote: @@ -434,12 +433,12 @@ static int link_alt_odb_entry_the_repository(const char *entry, ent = alloc_alt_odb(pathbuf.buf); /* add the alternate entry */ -

Re: [PATCH 025/194] object-store: allow prepare_alt_odb to handle arbitrary repositories

2018-02-05 Thread brian m. carlson
On Mon, Feb 05, 2018 at 03:54:46PM -0800, Stefan Beller wrote: > @@ -434,12 +433,12 @@ static int link_alt_odb_entry_the_repository(const char > *entry, > ent = alloc_alt_odb(pathbuf.buf); > > /* add the alternate entry */ > - *the_repository->objects.alt_odb_tail = ent; > -

[PATCH 025/194] object-store: allow prepare_alt_odb to handle arbitrary repositories

2018-02-05 Thread Stefan Beller
Signed-off-by: Jonathan Nieder Signed-off-by: Stefan Beller Signed-off-by: Jonathan Nieder --- cache.h| 4 object-store.h | 3 +-- sha1_file.c| 63 ++ 3 files