Re: [PATCH 03/15] t: use test_decode_color rather than literal ANSI codes

2017-07-14 Thread Jeff King
On Thu, Jul 13, 2017 at 12:27:41PM -0700, Junio C Hamano wrote: > > I agree it's a bit gross. Possibly: > > > > git log --format='%C(auto)%d %s' > > > > would be easier for the test to parse (I'm pretty sure that didn't exist > > back when this test was written). > > Yeah, that may make the

Re: [PATCH 03/15] t: use test_decode_color rather than literal ANSI codes

2017-07-13 Thread Junio C Hamano
Jeff King writes: > When we put literal ANSI terminal codes into our test > scripts, it makes diffs on those scripts hard to read (the > colors may be indistinguishable from diff coloring, or in > the case of a reset, may not be visible at all). > > Some scripts get around this by

Re: [PATCH 03/15] t: use test_decode_color rather than literal ANSI codes

2017-07-13 Thread Junio C Hamano
Jeff King writes: >> > @@ -59,7 +54,8 @@ EOF >> > # to this test since it does not contain any decoration, hence >> > --first-parent >> > test_expect_success 'Commit Decorations Colored Correctly' ' >> > git log --first-parent --abbrev=10 --all --decorate --oneline >>

Re: [PATCH 03/15] t: use test_decode_color rather than literal ANSI codes

2017-07-13 Thread Jeff King
On Thu, Jul 13, 2017 at 11:40:32AM -0700, Stefan Beller wrote: > On Thu, Jul 13, 2017 at 7:58 AM, Jeff King wrote: > > > I really only need t6300 and t6006 converted to build on for the rest of > > the series. But t4207 was easy to do. t4026 still uses raw codes, but > >

Re: [PATCH 03/15] t: use test_decode_color rather than literal ANSI codes

2017-07-13 Thread Stefan Beller
On Thu, Jul 13, 2017 at 7:58 AM, Jeff King wrote: > I really only need t6300 and t6006 converted to build on for the rest of > the series. But t4207 was easy to do. t4026 still uses raw codes, but > converting it would be a pretty big job, so I punted. > I think it is good to

[PATCH 03/15] t: use test_decode_color rather than literal ANSI codes

2017-07-13 Thread Jeff King
When we put literal ANSI terminal codes into our test scripts, it makes diffs on those scripts hard to read (the colors may be indistinguishable from diff coloring, or in the case of a reset, may not be visible at all). Some scripts get around this by including human-readable names and converting