Re: [PATCH 03/19] reset.c: pass pathspec around instead of (prefix, argv) pair

2013-01-11 Thread Duy Nguyen
On Fri, Jan 11, 2013 at 6:09 AM, Junio C Hamano gits...@pobox.com wrote: Or I could hold off nd/parse-pathspec if this series has a better chance of graduation first. Decision? I am greedy and want to have both ;-) Apparently I have no problems with your being greedy. There is no textual

Re: [PATCH 03/19] reset.c: pass pathspec around instead of (prefix, argv) pair

2013-01-10 Thread Duy Nguyen
On Thu, Jan 10, 2013 at 2:26 AM, Junio C Hamano gits...@pobox.com wrote: Martin von Zweigbergk martinv...@gmail.com writes: We use the path arguments in two places in reset.c: in interactive_reset() and read_from_tree(). Both of these call get_pathspec(), so we pass the (prefix, arv) pair to

Re: [PATCH 03/19] reset.c: pass pathspec around instead of (prefix, argv) pair

2013-01-10 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: On Thu, Jan 10, 2013 at 2:26 AM, Junio C Hamano gits...@pobox.com wrote: Martin von Zweigbergk martinv...@gmail.com writes: We use the path arguments in two places in reset.c: in interactive_reset() and read_from_tree(). Both of these call

[PATCH 03/19] reset.c: pass pathspec around instead of (prefix, argv) pair

2013-01-09 Thread Martin von Zweigbergk
We use the path arguments in two places in reset.c: in interactive_reset() and read_from_tree(). Both of these call get_pathspec(), so we pass the (prefix, arv) pair to both functions. Move the call to get_pathspec() out of these methods, for two reasons: 1) One argument is simpler than two. 2) It

Re: [PATCH 03/19] reset.c: pass pathspec around instead of (prefix, argv) pair

2013-01-09 Thread Matt Kraai
On Wed, Jan 09, 2013 at 12:16:00AM -0800, Martin von Zweigbergk wrote: We use the path arguments in two places in reset.c: in interactive_reset() and read_from_tree(). Both of these call get_pathspec(), so we pass the (prefix, arv) pair to both ^^^ argv

Re: [PATCH 03/19] reset.c: pass pathspec around instead of (prefix, argv) pair

2013-01-09 Thread Junio C Hamano
Martin von Zweigbergk martinv...@gmail.com writes: We use the path arguments in two places in reset.c: in interactive_reset() and read_from_tree(). Both of these call get_pathspec(), so we pass the (prefix, arv) pair to both functions. Move the call to get_pathspec() out of these methods, for