Re: [PATCH 04/11] ref_transaction_update(): remove have_old parameter

2015-02-11 Thread Michael Haggerty
On 02/09/2015 07:20 PM, Stefan Beller wrote: On Sun, Feb 8, 2015 at 8:13 AM, Michael Haggerty mhag...@alum.mit.edu wrote: Instead, if old_sha1 is non-NULL, verify it; otherwise, don't. parsing error on that commit message. I needed to read the code to understand what you want to say here.

Re: [PATCH 04/11] ref_transaction_update(): remove have_old parameter

2015-02-09 Thread Stefan Beller
On Sun, Feb 8, 2015 at 8:13 AM, Michael Haggerty mhag...@alum.mit.edu wrote: Instead, if old_sha1 is non-NULL, verify it; otherwise, don't. parsing error on that commit message. I needed to read the code to understand what you want to say here. The code itself is Reviewed-by: Stefan Beller

[PATCH 04/11] ref_transaction_update(): remove have_old parameter

2015-02-08 Thread Michael Haggerty
Instead, if old_sha1 is non-NULL, verify it; otherwise, don't. ref_transaction_delete() will get the same treatment in a moment. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- branch.c | 5 +++-- builtin/commit.c | 2 +- builtin/fetch.c| 6 --