Re: [PATCH 04/12] refs: implement simple transactions for the packed-refs file

2013-06-12 Thread Jeff King
On Tue, Jun 11, 2013 at 11:48:24PM +0200, Michael Haggerty wrote: The API docs are not clear about whether it is kosher to read lock_file::fd directly. It is only done in one file outside of lockfile.c. So this patch stores the fd of the lockfile separately in struct packed_ref_cache, even

[PATCH 04/12] refs: implement simple transactions for the packed-refs file

2013-06-11 Thread Michael Haggerty
Handle simple transactions for the packed-refs file at the packed_ref_cache level via new functions lock_packed_refs(), commit_packed_refs(), and rollback_packed_refs(). Only allow the packed ref cache to be modified (via add_packed_ref()) while the packed refs file is locked. Change clone to