Re: [PATCH 06/16] diff: always try to set up the repository

2016-09-13 Thread Jeff King
On Tue, Sep 13, 2016 at 03:00:17PM -0700, Stefan Beller wrote: > On Mon, Sep 12, 2016 at 8:23 PM, Jeff King wrote: > > > 2. If you're in a subdirectory of a repository, then we > > still try to read ".git/config", but it generally > > doesn't exist. So "diff

Re: [PATCH 06/16] diff: always try to set up the repository

2016-09-13 Thread Stefan Beller
On Mon, Sep 12, 2016 at 8:23 PM, Jeff King wrote: > 2. If you're in a subdirectory of a repository, then we > still try to read ".git/config", but it generally > doesn't exist. So "diff --no-index" there does not > respect repo config. Nit: So IIUC your cover

[PATCH 06/16] diff: always try to set up the repository

2016-09-12 Thread Jeff King
If we see an explicit "--no-index", we do not bother calling setup_git_directory_gently() at all. This means that we may miss out on reading repo-specific config. It's arguable whether this is correct or not. If we were designing from scratch, making "git diff --no-index" completely ignore the