Re: [PATCH 09/19] index-helper: add Windows support

2016-03-19 Thread Johannes Schindelin
Hi Duy, On Wed, 16 Mar 2016, Duy Nguyen wrote: > I think it's safe to drop this patch now. It's mostly to prove that it > could work on Windows. But I don't think it's tested a lot (even I > only occasionally test it under wine). I agree that it is more important to get the basics right (such

Re: [PATCH 09/19] index-helper: add Windows support

2016-03-19 Thread Duy Nguyen
I think it's safe to drop this patch now. It's mostly to prove that it could work on Windows. But I don't think it's tested a lot (even I only occasionally test it under wine). On Thu, Mar 10, 2016 at 1:36 AM, David Turner wrote: > From: Nguyễn Thái Ngọc Duy

Re: [PATCH 09/19] index-helper: add Windows support

2016-03-19 Thread Duy Nguyen
On Thu, Mar 17, 2016 at 7:18 PM, Johannes Schindelin wrote: > Please note that there is one very important difference between Windows vs > Linux when it comes to shared memory: on Windows, the memory is released > as soon as the last user goes away. I assume that can

[PATCH 09/19] index-helper: add Windows support

2016-03-09 Thread David Turner
From: Nguyễn Thái Ngọc Duy Windows supports shared memory, but the semantics is a bit different than POSIX shm. The most noticeable thing is there's no way to get the shared memory's size by the reader, and wrapping fstat to do that would be hell. So the shm size is added near