Re: [PATCH 1/1] rebase: really just passthru the `git am` options

2018-11-14 Thread Johannes Schindelin
Hi Phillip, On Tue, 13 Nov 2018, Phillip Wood wrote: > On 13/11/2018 19:21, Johannes Schindelin wrote: > > Hi Phillip, > > > > On Tue, 13 Nov 2018, Phillip Wood wrote: > > > > > Thanks for looking at this. Unfortunately using OPT_PASSTHRU_ARGV seems to > > > break the error reporting > > > > >

Re: [PATCH 1/1] rebase: really just passthru the `git am` options

2018-11-13 Thread Phillip Wood
Hi Johannes On 13/11/2018 19:21, Johannes Schindelin wrote: Hi Phillip, On Tue, 13 Nov 2018, Phillip Wood wrote: Thanks for looking at this. Unfortunately using OPT_PASSTHRU_ARGV seems to break the error reporting Running bin/wrappers/git rebase --onto @ @^^ -Cbad Gives git

Re: [PATCH 1/1] rebase: really just passthru the `git am` options

2018-11-13 Thread Johannes Schindelin
Hi Phillip, On Tue, 13 Nov 2018, Phillip Wood wrote: > Thanks for looking at this. Unfortunately using OPT_PASSTHRU_ARGV seems to > break the error reporting > > Running > bin/wrappers/git rebase --onto @ @^^ -Cbad > > Gives > git encountered an error while preparing the patches to

Re: [PATCH 1/1] rebase: really just passthru the `git am` options

2018-11-13 Thread Phillip Wood
Hi Johannes Thanks for looking at this. Unfortunately using OPT_PASSTHRU_ARGV seems to break the error reporting Running bin/wrappers/git rebase --onto @ @^^ -Cbad Gives git encountered an error while preparing the patches to replay these revisions:

Re: [PATCH 1/1] rebase: really just passthru the `git am` options

2018-11-13 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > However, there is a much better way (that I was unaware of, at the time > when I mentored Pratik to implement these options): OPT_PASSTHRU_ARGV. > It is intended for exactly this use case, where command-line options > want to be parsed into a

[PATCH 1/1] rebase: really just passthru the `git am` options

2018-11-13 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin Currently, we parse the options intended for `git am` as if we wanted to handle them in `git rebase`, and then reconstruct them painstakingly to define the `git_am_opt` variable. However, there is a much better way (that I was unaware of, at the time when I mentored