RE: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-05 Thread Joachim Schmitz
From: Junio C Hamano [mailto:gits...@pobox.com] Sent: Wednesday, September 05, 2012 12:45 AM To: Joachim Schmitz Cc: git@vger.kernel.org; 'Johannes Sixt' Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it Joachim Schmitz j...@schmitz-digital.de writes: From: Junio

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-04 Thread Junio C Hamano
Joachim Schmitz j...@schmitz-digital.de writes: Only with the observation of clone, I cannot tell if your timer is working. You can try repacking the test repository you created by your earlier git clone with git repack -a -d -f and see what happens. It does update the counter too. Yeah,

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-04 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Joachim Schmitz j...@schmitz-digital.de writes: Only with the observation of clone, I cannot tell if your timer is working. You can try repacking the test repository you created by your earlier git clone with git repack -a -d -f and see what

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-04 Thread Johannes Sixt
Am 04.09.2012 19:23, schrieb Joachim Schmitz: From: Junio C Hamano [mailto:gits...@pobox.com] Only with the observation of clone, I cannot tell if your timer is working. You can try repacking the test repository you created by your earlier git clone with git repack -a -d -f and see what

RE: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-04 Thread Joachim Schmitz
From: Junio C Hamano [mailto:gits...@pobox.com] Sent: Tuesday, September 04, 2012 8:47 PM To: Joachim Schmitz Cc: git@vger.kernel.org; 'Johannes Sixt' Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it Junio C Hamano gits...@pobox.com writes: Joachim Schmitz j

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-04 Thread Junio C Hamano
Joachim Schmitz j...@schmitz-digital.de writes: From: Junio C Hamano [mailto:gits...@pobox.com] Sent: Tuesday, September 04, 2012 8:47 PM To: Joachim Schmitz Cc: git@vger.kernel.org; 'Johannes Sixt' Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it Junio C Hamano

RE: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-03 Thread Joachim Schmitz
From: Junio C Hamano [mailto:gits...@pobox.com] Sent: Sunday, September 02, 2012 10:44 PM To: Joachim Schmitz Cc: git@vger.kernel.org; Johannes Sixt Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it Joachim Schmitz j...@schmitz-digital.de writes: Should we

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-03 Thread Junio C Hamano
Johannes Sixt j...@kdbg.org writes: Am 03.09.2012 11:31, schrieb Joachim Schmitz: Hmm, I see that there the errors are handled differently, like this: if (ovalue != NULL) return errno = EINVAL, error(setitimer param 3 != NULL not

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-03 Thread Junio C Hamano
Joachim Schmitz j...@schmitz-digital.de writes: if (!value ) { Style: space before ')'? Will fix. errno = EFAULT; return -1; EFAULT is good ;-) That's what 'man setitimer()' on Linux says to happen if invalid value is found. The emulation in

RE: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-03 Thread Joachim Schmitz
From: Junio C Hamano [mailto:gits...@pobox.com] Sent: Monday, September 03, 2012 9:03 PM To: Joachim Schmitz Cc: git@vger.kernel.org; 'Johannes Sixt' Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it Joachim Schmitz j...@schmitz-digital.de writes: if (!value

RE: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-01 Thread Joachim Schmitz
From: Joachim Schmitz [mailto:j...@schmitz-digital.de] Sent: Thursday, August 30, 2012 7:23 PM To: 'Junio C Hamano' Cc: 'git@vger.kernel.org' Subject: RE: [PATCH 1/2] Support for setitimer() on platforms lacking it From: Junio C Hamano [mailto:gits...@pobox.com] Sent: Thursday, August

RE: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-08-30 Thread Joachim Schmitz
From: Junio C Hamano [mailto:gits...@pobox.com] Sent: Tuesday, August 28, 2012 10:16 PM To: Joachim Schmitz Cc: git@vger.kernel.org Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it Joachim Schmitz j...@schmitz-digital.de writes: Implementation includes getitimer

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-08-30 Thread Junio C Hamano
Joachim Schmitz j...@schmitz-digital.de writes: I see no existing code calls setitimer() with non-NULL ovalue, and I do not think we would add a new caller that would do so in any time soon, so it may not be a bad idea to drop support of returning the remaining timer altogether from this

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-08-28 Thread Junio C Hamano
Joachim Schmitz j...@schmitz-digital.de writes: Implementation includes getitimer(), but for now it is static. Supports ITIMER_REAL only. Signed-off-by: Joachim Schmitz j...@schmitz-digital.de --- May need a header file for ITIMER_*, struct itimerval and the prototypes, But for now, and

[PATCH 1/2] Support for setitimer() on platforms lacking it

2012-08-24 Thread Joachim Schmitz
Implementation includes getitimer(), but for now it is static. Supports ITIMER_REAL only. Signed-off-by: Joachim Schmitz j...@schmitz-digital.de --- May need a header file for ITIMER_*, struct itimerval and the prototypes, But for now, and the HP NonStop platform this isn't needed, here sys/time