Re: [PATCH 1/2] p4merge: swap LOCAL and REMOTE for mergetool

2013-03-07 Thread Junio C Hamano
David Aguilar writes: > I would prefer to treat this as a bugfix rather than introducing > a new set of configuration knobs if possible. It really does > seem like a correction. > > Users that want the traditional behavior can get that by > configuring a custom mergetool.p4merge.cmd, so we're n

Re: [PATCH 1/2] p4merge: swap LOCAL and REMOTE for mergetool

2013-03-07 Thread David Aguilar
On Thu, Mar 7, 2013 at 11:10 AM, Junio C Hamano wrote: > Kevin Bracey writes: > >> On 07/03/2013 09:23, Junio C Hamano wrote: >>> If p4merge GUI labels one side clearly as "theirs" and the other >>> "ours", and the way we feed the inputs to it makes the side that is >>> actually "ours" appear in

Re: [PATCH 1/2] p4merge: swap LOCAL and REMOTE for mergetool

2013-03-07 Thread Junio C Hamano
Kevin Bracey writes: > On 07/03/2013 09:23, Junio C Hamano wrote: >> If p4merge GUI labels one side clearly as "theirs" and the other >> "ours", and the way we feed the inputs to it makes the side that is >> actually "ours" appear in p4merge GUI labelled as "theirs", then I >> do not think backwa

Re: [PATCH 1/2] p4merge: swap LOCAL and REMOTE for mergetool

2013-03-07 Thread Kevin Bracey
On 07/03/2013 09:23, Junio C Hamano wrote: If p4merge GUI labels one side clearly as "theirs" and the other "ours", and the way we feed the inputs to it makes the side that is actually "ours" appear in p4merge GUI labelled as "theirs", then I do not think backward compatibility argument does no

Re: [PATCH 1/2] p4merge: swap LOCAL and REMOTE for mergetool

2013-03-06 Thread Junio C Hamano
Kevin Bracey writes: > I agree that this is the controversial patch of the two. It's going to > chuck away 3-4 years of what Git users are used to, albeit in favour > of a decade of what Perforce users are used to. And it also makes it > inconsistent with all the other mergetools (at least assumi

Re: [PATCH 1/2] p4merge: swap LOCAL and REMOTE for mergetool

2013-03-06 Thread Kevin Bracey
On 07/03/2013 02:36, Junio C Hamano wrote: Kevin Bracey writes: Reverse LOCAL and REMOTE when invoking P4Merge as a mergetool, so that the incoming branch is now in the left-hand, blue triangle pane, and the current branch is in the right-hand, green circle pane. Given that the ordering of th

Re: [PATCH 1/2] p4merge: swap LOCAL and REMOTE for mergetool

2013-03-06 Thread Junio C Hamano
Kevin Bracey writes: > Reverse LOCAL and REMOTE when invoking P4Merge as a mergetool, so that > the incoming branch is now in the left-hand, blue triangle pane, and the > current branch is in the right-hand, green circle pane. Given that the ordering of the three variants has been the way it is

[PATCH 1/2] p4merge: swap LOCAL and REMOTE for mergetool

2013-03-06 Thread Kevin Bracey
Reverse LOCAL and REMOTE when invoking P4Merge as a mergetool, so that the incoming branch is now in the left-hand, blue triangle pane, and the current branch is in the right-hand, green circle pane. This change makes use of P4Merge consistent with its built-in help, its reference documentation, a