Re: [PATCH 1/2] rebase: consolidate clean-up code before leaving reset_head()

2018-11-09 Thread Johannes Schindelin
Hi Peff, On Fri, 9 Nov 2018, Jeff King wrote: > On Fri, Nov 09, 2018 at 01:34:17AM -0800, Johannes Schindelin via > GitGitGadget wrote: > > > diff --git a/builtin/rebase.c b/builtin/rebase.c > > index 0ee06aa363..6f6d7de156 100644 > > --- a/builtin/rebase.c > > +++ b/builtin/rebase.c > > @@

Re: [PATCH 1/2] rebase: consolidate clean-up code before leaving reset_head()

2018-11-09 Thread Jeff King
On Fri, Nov 09, 2018 at 01:34:17AM -0800, Johannes Schindelin via GitGitGadget wrote: > diff --git a/builtin/rebase.c b/builtin/rebase.c > index 0ee06aa363..6f6d7de156 100644 > --- a/builtin/rebase.c > +++ b/builtin/rebase.c > @@ -569,16 +569,13 @@ static int reset_head(struct object_id *oid,

[PATCH 1/2] rebase: consolidate clean-up code before leaving reset_head()

2018-11-09 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin The same clean-up code is repeated quite a few times; Let's DRY up the code some. Signed-off-by: Johannes Schindelin --- builtin/rebase.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/builtin/rebase.c b/builtin/rebase.c index