Re: [PATCH 1/2] serialize collection of changed submodules

2016-09-19 Thread Heiko Voigt
On Fri, Sep 16, 2016 at 10:27:04AM -0700, Junio C Hamano wrote: > Heiko Voigt writes: > > > +static struct sha1_array *get_sha1s_from_list(struct string_list > > *submodules, > > + const char *path) > > +{ > > + struct string_list_item *item; > > + struct

Re: [PATCH 1/2] serialize collection of changed submodules

2016-09-16 Thread Junio C Hamano
Heiko Voigt writes: > +static struct sha1_array *get_sha1s_from_list(struct string_list *submodules, > + const char *path) > +{ > + struct string_list_item *item; > + struct sha1_array *hashes; > + > + item = string_list_insert(submodules, path); > +

Re: [PATCH 1/2] serialize collection of changed submodules

2016-09-14 Thread Junio C Hamano
Heiko Voigt writes: > Sorry about the late reply. I was not able to process emails until now. > Here are two patches that should help to improve the situation and batch > up some processing. This one is for repositories with submodules, so > that they do not iterate over the

[PATCH 1/2] serialize collection of changed submodules

2016-09-14 Thread Heiko Voigt
To check whether a submodule needs to be pushed we need to collect all changed submodules. Lets collect them first and then execute the possibly expensive test whether certain revisions are already pushed only once per submodule. There is further potential for optimization since we can assemble